build: add support for armv7 binary release #956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 71.34% 71.87% +0.52%
==========================================
Files 45 46 +1
Lines 2174 2229 +55
==========================================
+ Hits 1551 1602 +51
- Misses 429 431 +2
- Partials 194 196 +2 ☔ View full report in Codecov by Sentry. |
|
@lmussier Could you fix the DCO check? |
shizhMSFT
left a comment
There was a problem hiding this comment.
The change itself LGTM but the DCO needs to be fixed.
|
@lmussier Thanks for your contribution. You may refer to this doc to fix the DCO issue and submit signed git commit: https://github.com/notaryproject/.github/blob/main/CONTRIBUTING.md#commit |
I'll do. |
32e8a23 to
ff9b906
Compare
Signed-off-by: lmussier <ludovic.mussier@gmail.com>
|
Should be good know. |
|
Hi @notaryproject/notaryproject-notation-maintainers anything I have to do to retrigger a DCO check - I lmight have missed something also... |
|
@lmussier Could you force push again to fix the DCO issue? It hangs because of the GitHub bugs at that time. |
|
@lmussier Could you try this comment to generate a new commit id and push it again. Thanks! git commit --amend --no-edit |
d9788e8 to
ec15b08
Compare
Done but might have messedup the signature, this new commit is not 'verified' for github. |
|
@lmussier Please try: git commit --amend --no-edit -S |
…darwin Signed-off-by: lmussier <ludovic.mussier@gmail.com>
Modify targeted goarch and ignore irrelevant configs (e.g windows/arm and darwin/ arm) Signed-off-by: lmussier <ludovic.mussier@gmail.com>
Modify targeted goarch and ignore irrelevant configs (e.g windows/arm and darwin/ arm) Signed-off-by: lmussier <ludovic.mussier@gmail.com>
Modify targeted goarch and ignore irelevant configs (e.g windows / arm and darwi n/ arm)