feat: add notation config environment variable #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 64.05% 64.42% +0.36%
==========================================
Files 40 40
Lines 2323 2330 +7
==========================================
+ Hits 1488 1501 +13
+ Misses 709 705 -4
+ Partials 126 124 -2 ☔ View full report in Codecov by Sentry. |
|
Quick question: Is this feat been tested anywhere? Maybe an E2E test case (if doable)? |
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
4a0ddd2 to
7144e6c
Compare
Contributor
|
What's the necessity for this? Can't the user utilize XDG_CONFIG_HOME on windows and mac? |
Contributor
6 tasks
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
Feat: - added NOTATION_CONFIG and NOTATION_LIBEXEC environment variables Test: - notation sign with NOTATION_LIBEXEC locally - notation verify with NOTATION_CONFIG locally Resolves notaryproject#822 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
Feat: - added NOTATION_CONFIG and NOTATION_LIBEXEC environment variables Test: - notation sign with NOTATION_LIBEXEC locally - notation verify with NOTATION_CONFIG locally Resolves notaryproject#822 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Feat: - added NOTATION_CONFIG and NOTATION_LIBEXEC environment variables Test: - notation sign with NOTATION_LIBEXEC locally - notation verify with NOTATION_CONFIG locally Resolves notaryproject#822 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Feat: - added NOTATION_CONFIG and NOTATION_LIBEXEC environment variables Test: - notation sign with NOTATION_LIBEXEC locally - notation verify with NOTATION_CONFIG locally Resolves notaryproject#822 Signed-off-by: Junjie Gao <junjiegao@microsoft.com> --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat:
Test:
Resolves #822
Signed-off-by: Junjie Gao junjiegao@microsoft.com