Skip to content

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Jun 27, 2023

Update:

  • update testdata OCI layout images from OCI Artifact to OCI Image format
  • update ginkgo version

Fix:

Resolves #726
Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review June 27, 2023 06:25
@JeyJeyGao JeyJeyGao requested a review from a user June 27, 2023 06:25
@JeyJeyGao JeyJeyGao changed the title fix(e2e): update testdata oci layout images fix(e2e): update testdata OCI layout images Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.66%. Comparing base (0f3c4ae) to head (499f47b).
⚠️ Report is 337 commits behind head on main.

❌ Your project status has failed because the head coverage (63.66%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #727       +/-   ##
===========================================
+ Coverage   46.59%   63.66%   +17.06%     
===========================================
  Files          40       40               
  Lines        2232     2232               
===========================================
+ Hits         1040     1421      +381     
+ Misses       1105      690      -415     
- Partials       87      121       +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 77eb77a into notaryproject:main Jun 30, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
- update testdata OCI layout images from OCI Artifact to OCI Image format
- update ginkgo version

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
- update testdata OCI layout images from OCI Artifact to OCI Image format
- update ginkgo version

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E test failed but still passed CI

4 participants