Skip to content

Conversation

@FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented Jun 9, 2023

Update RELEASE_CHECKLIST.md per suggestions from Notary Project community meeting and notaryproject/.github#28. Please note that this PR focuses on updating the Notation CLI release process only.

I will create another PR to add the release checklist for releasing a patch.

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeynmanZhou

@yizha1 yizha1 linked an issue Jun 12, 2023 that may be closed by this pull request
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (c9d3997) to head (74be9f5).
Report is 153 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   63.77%   71.34%   +7.56%     
==========================================
  Files          40       45       +5     
  Lines        2228     2174      -54     
==========================================
+ Hits         1421     1551     +130     
+ Misses        686      429     -257     
- Partials      121      194      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou requested a review from a user June 19, 2023 08:54
ghost
ghost previously approved these changes Jun 19, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou added the governance Community governnance label Jul 17, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
15 tasks
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
ghost
ghost previously approved these changes Aug 8, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Aug 8, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title update RELEASE_CHECKLIST.md docs: update RELEASE_CHECKLIST.md Nov 3, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou dismissed stale reviews from shizhMSFT and ghost via c569b95 November 6, 2023 23:40
@FeynmanZhou FeynmanZhou requested review from a user and shizhMSFT November 6, 2023 23:40
@github-actions
Copy link

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 22, 2024
@yizha1 yizha1 removed the Stale label Mar 22, 2024
@yizha1 yizha1 added this to the 1.2.0 milestone Mar 22, 2024
@FeynmanZhou FeynmanZhou requested a review from a user June 4, 2024 00:18
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Include Patrick's comment

Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou merged commit cab4fef into notaryproject:main Jul 16, 2024
@ghost ghost mentioned this pull request Jul 23, 2024
7 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Update RELEASE_CHECKLIST.md per suggestions from [Notary Project
community meeting](https://hackmd.io/_vrqBGAOSUC_VWvFzWruZw?view#Notes)
and notaryproject/.github#28. Please note that
this PR focuses on updating the Notation CLI release process only.

I will create another PR to add the release checklist for releasing a
patch.

---------

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou added a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Update RELEASE_CHECKLIST.md per suggestions from [Notary Project
community meeting](https://hackmd.io/_vrqBGAOSUC_VWvFzWruZw?view#Notes)
and notaryproject/.github#28. Please note that
this PR focuses on updating the Notation CLI release process only.

I will create another PR to add the release checklist for releasing a
patch.

---------

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

governance Community governnance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor and migrate the release guideline

7 participants