Skip to content

Conversation

@mintbomb27
Copy link
Contributor

Fixes #535

I wasn't able to find a Dockerfile. If you could guide me, I will change it there too @shizhMSFT

Signed-off-by: alok-n2020 <alok.n2020@vitstudent.ac.in>
@shizhMSFT
Copy link
Contributor

shizhMSFT commented Feb 6, 2023

Thank @mintbomb27 for pointing out the Dockerfile issue. Currently, notation CLI does not have a Dockerfile. I've updated the issue accordingly.

Signed-off-by: alok-n2020 <alok.n2020@vitstudent.ac.in>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #538 (c231b8f) into main (f463f0c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   35.15%   35.15%           
=======================================
  Files          29       29           
  Lines        1502     1502           
=======================================
  Hits          528      528           
  Misses        955      955           
  Partials       19       19           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 5c27944 into notaryproject:main Feb 6, 2023
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Fixes notaryproject#535 (Bump up golang to 1.20)

Signed-off-by: alok-n2020 <alok.n2020@vitstudent.ac.in>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Fixes notaryproject#535 (Bump up golang to 1.20)

Signed-off-by: alok-n2020 <alok.n2020@vitstudent.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump up golang to 1.20

5 participants