Skip to content

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Mar 4, 2025

Release pipeline with warnings: https://github.com/notaryproject/notation/actions/runs/13489436510/job/37685202798

Fix:

Test:

  • tested release pipeline in forked repo

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.22%. Comparing base (1e5e342) to head (1892032).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files          71       71           
  Lines        3634     3634           
=======================================
  Hits         2770     2770           
  Misses        668      668           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review March 4, 2025 08:24
@JeyJeyGao JeyJeyGao requested a review from a user March 4, 2025 08:24
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 18018da into notaryproject:main Mar 6, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the fix/goreleaser branch March 6, 2025 05:57
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Release pipeline with **warnings**:
https://github.com/notaryproject/notation/actions/runs/13489436510/job/37685202798

Fix:
- locked goreleaser version to v2
- added configuration `version: 2`:
https://goreleaser.com/errors/version/?h=configuration+version#unsupported-configuration-version
- updated deprecated 
- `format` option: https://goreleaser.com/deprecations/#archivesformat
- `overrides.format` option:
https://goreleaser.com/deprecations/#archivesformat_overridesformat


Test:
- tested release pipeline in forked repo

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Release pipeline with **warnings**:
https://github.com/notaryproject/notation/actions/runs/13489436510/job/37685202798

Fix:
- locked goreleaser version to v2
- added configuration `version: 2`:
https://goreleaser.com/errors/version/?h=configuration+version#unsupported-configuration-version
- updated deprecated 
- `format` option: https://goreleaser.com/deprecations/#archivesformat
- `overrides.format` option:
https://goreleaser.com/deprecations/#archivesformat_overridesformat


Test:
- tested release pipeline in forked repo

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants