Skip to content

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Feb 14, 2025

Added OCSP E2E test cases: valid, revoked and unknown

OCSP fallback to CRL test cases have been included in #1079

Resolves #638
Resolves #572

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (73b1551) to head (35a68e1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          60       60           
  Lines        3365     3365           
=======================================
  Hits         2533     2533           
  Misses        640      640           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review February 14, 2025 03:13
@JeyJeyGao JeyJeyGao requested a review from a user February 14, 2025 03:13
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 1a120fd into notaryproject:main Feb 14, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the test/ocsp_e2e branch February 14, 2025 05:56
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Added OCSP E2E test cases: valid, revoked and unknown

OCSP fallback to CRL test cases have been included in notaryproject#1079 

Resolves notaryproject#638
Resolves notaryproject#572

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Added OCSP E2E test cases: valid, revoked and unknown

OCSP fallback to CRL test cases have been included in notaryproject#1079 

Resolves notaryproject#638
Resolves notaryproject#572

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add E2E test cases for validating certificate revocation with OCSP [revocation] Write e2e tests for revocation using CRL and OCSP

2 participants