Skip to content

refactor: verify display handler #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeyJeyGao merged 39 commits into from
Feb 11, 2025
Merged

refactor: verify display handler #1167

JeyJeyGao merged 39 commits into from
Feb 11, 2025

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Feb 7, 2025 •
edited
Loading

Refactor:

  • move the verify command output related logic to be VerifyHandler

Example:

notation verify notationreg.azurecr.io/hello-world:v1
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable.

Successfully verified signature for notationreg.azurecr.io/hello-world@sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7

The artifact was signed with the following user metadata.

KEY   VALUE
foo   bar

Resolve part of #1151

@JeyJeyGao
refactor: add inpect display handler
89adf15 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update code
f0756a8 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add unit test
578dea2 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add e2e test for tree and json
24dea8b 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
refactor code
4031faf 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update E2E
37b967a 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comments
c2697db 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update license header
edbfbad 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update test
eb078e3 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add unit test
4d3aedd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add unit test for inspect
8fdc989 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: update test
0640165 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comemnts
a1e411f 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: test
84a1991 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: remove envelope media type
8083c25 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: e2e test
5dd55ca 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: e2e test
25bc6a0 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update json output format
fd74cf7 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update e2e
f1c2966 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: add content type in json output
89b310f 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add e2e test for invalid timestamp signature
58603ce 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update e2e test
b3a97e5 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: unit test
b108fcd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comments
721518a 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comments
0997875 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
refactor: display package structure
aef5735 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update to use *ocispec.Descriptor
5b28eda 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: restore package structure
8f5d88f 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: restore "NewInpsectHandler" function name
1adc392 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: move internal/tree to tree handlers package
da16190 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'upstream/main' into refactor/verify_out…
7b4961f 
…put_handler
@JeyJeyGao
fix: update code
a029bd2 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao marked this pull request as ready for review February 8, 2025 05:04
@JeyJeyGao JeyJeyGao requested a review from a user February 8, 2025 05:04
@JeyJeyGao JeyJeyGao mentioned this pull request Feb 8, 2025
Closed
5 tasks
shizhMSFT
shizhMSFT previously approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@JeyJeyGao
fix: resolve comment
1f6e1c0 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
ghost reviewed Feb 10, 2025
View reviewed changes
@JeyJeyGao
fix: resolve comments
e33dc04 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
fix: add an empty line between warning and final message
0485b7f 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao requested a review from a user February 11, 2025 02:28
ghost
ghost approved these changes Feb 11, 2025
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 73b1551 into notaryproject:main Feb 11, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the refactor/verify_output_handler branch February 11, 2025 05:50
This was referenced Mar 12, 2025
Closed
Merged
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
@JeyJeyGao @7h3-3mp7y-m4n
refactor: verify display handler (notaryproject#1167)
ebcb9c7 
Refactor:
- move the verify command output related logic to be `VerifyHandler`

Example:
```sh
notation verify notationreg.azurecr.io/hello-world:v1
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable.

Successfully verified signature for notationreg.azurecr.io/hello-world@sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7

The artifact was signed with the following user metadata.

KEY   VALUE
foo   bar
```

Resolve part of notaryproject#1151

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
@JeyJeyGao @FeynmanZhou
refactor: verify display handler (notaryproject#1167)
e3c2931 
Refactor:
- move the verify command output related logic to be `VerifyHandler`

Example:
```sh
notation verify notationreg.azurecr.io/hello-world:v1
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:v1) because resolved digest may not point to the same signed artifact, as tags are mutable.

Successfully verified signature for notationreg.azurecr.io/hello-world@sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7

The artifact was signed with the following user metadata.

KEY   VALUE
foo   bar
```

Resolve part of notaryproject#1151

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeyJeyGao @shizhMSFT