Skip to content

Conversation

@DalderupMaurice
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #1041 into develop will increase coverage by 1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #1041      +/-   ##
==========================================
+ Coverage    51.48%   52.5%   +1.01%     
==========================================
  Files          237     240       +3     
  Lines         2016    2040      +24     
  Branches       267     278      +11     
==========================================
+ Hits          1038    1071      +33     
+ Misses         813     802      -11     
- Partials       165     167       +2

@DalderupMaurice DalderupMaurice merged commit d2aab99 into develop Jul 28, 2019
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants