Skip to content

chore(main): ignore gpu blacklist for hw acceleration #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 1 commit into from
Jul 28, 2019
Merged

chore(main): ignore gpu blacklist for hw acceleration #1038

DalderupMaurice merged 1 commit into from
Jul 28, 2019

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jul 27, 2019 •
edited
Loading

Description

Potentional fix for Your browser does not support WebGL

Motivation and Context

Hash Puppies didn't work for several people with low end GPUs

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Jul 27, 2019

Codecov Report

Merging #1038 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1038   +/-   ##
======================================
  Coverage    52.5%   52.5%           
======================================
  Files         240     240           
  Lines        2040    2040           
  Branches      278     278           
======================================
  Hits         1071    1071           
  Misses        802     802           
  Partials      167     167

@DalderupMaurice DalderupMaurice merged commit ef6df4b into master Jul 28, 2019
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jul 28, 2019
@DalderupMaurice DalderupMaurice deleted the hotfix/gpu-fix branch August 2, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DalderupMaurice