Skip to content

Fix the 'runbook_url' position in prometheus-rules file#1804

Merged
nimrod-becker merged 1 commit intonoobaa:masterfrom
liranmauda:liran-fix-runbook
Feb 17, 2026
Merged

Fix the 'runbook_url' position in prometheus-rules file#1804
nimrod-becker merged 1 commit intonoobaa:masterfrom
liranmauda:liran-fix-runbook

Conversation

@liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Feb 17, 2026 •
edited by coderabbitai bot
Loading

Fix the 'runbook_url' position in prometheus-rules file

Summary by CodeRabbit

  • Chores
    • Updated Prometheus alert rules configuration to properly associate runbook documentation URLs with NooBaa system capacity warning alerts, improving operational visibility and incident response guidance.

@aruniiird @liranmauda
Fix the 'runbook_url' position in prometheus-rules file
8d3505f 
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

📝 Walkthrough

Walkthrough

This PR updates Prometheus alert rules by repositioning the runbook_url field from the labels section to the annotations section for three NooBaa capacity warning alerts, and updates the corresponding SHA256 checksum to reflect the YAML file changes.

Changes

Cohort / File(s) Summary
Prometheus Rules Configuration
deploy/internal/prometheus-rules.yaml		 Moved runbook_url from labels to annotations for three alert rules: NooBaaSystemCapacityWarning85, NooBaaSystemCapacityWarning95, and NooBaaSystemCapacityWarning100.
Bundle Deployment
pkg/bundle/deploy.go		 Updated SHA256 checksum (Sha256_deploy_internal_prometheus_rules_yaml) to reflect YAML file changes; embedded YAML also reflects runbook_url repositioning in the same three alerts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/XS

Suggested reviewers

  • nimrod-becker
  • jackyalbo
  • dannyzaken
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and only repeats the title, missing all required template sections: explanation of changes, related issues, and testing instructions. Add detailed explanation of why runbook_url was moved, reference any related issues, and include testing instructions to verify the changes work correctly.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: moving runbook_url from labels to annotations in Prometheus alert rules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@liranmauda
Copy link
Contributor Author

liranmauda commented Feb 17, 2026

@aruniiird I took your commit and fixed the test, but could not push it to your branch and PR so I have opened this one.
Could you take a look?

@nimrod-becker nimrod-becker mentioned this pull request Feb 17, 2026
Closed
2 tasks
@nimrod-becker nimrod-becker merged commit aaea6b9 into noobaa:master Feb 17, 2026
15 checks passed
liranmauda added a commit to liranmauda/noobaa-operator that referenced this pull request Feb 17, 2026
@liranmauda @aruniiird
Fix the 'runbook_url' position in prometheus-rules file (noobaa#1804)
5dc2667 
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Co-authored-by: Arun Kumar Mohan <amohan@redhat.com>
(cherry picked from commit aaea6b9)
@liranmauda liranmauda mentioned this pull request Feb 17, 2026
Merged
liranmauda added a commit to liranmauda/noobaa-operator that referenced this pull request Feb 17, 2026
@liranmauda @aruniiird
Fix the 'runbook_url' position in prometheus-rules file (noobaa#1804)
fe54b0d 
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Co-authored-by: Arun Kumar Mohan <amohan@redhat.com>
(cherry picked from commit aaea6b9)
Signed-off-by: liranmauda <liran.mauda@gmail.com>
nimrod-becker pushed a commit that referenced this pull request Feb 17, 2026
@liranmauda @aruniiird
Fix the 'runbook_url' position in prometheus-rules file (#1804) (#1805)
61af41d 
(cherry picked from commit aaea6b9)

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Signed-off-by: liranmauda <liran.mauda@gmail.com>
Co-authored-by: Arun Kumar Mohan <amohan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liranmauda @nimrod-becker @aruniiird