ThanosRuleHighRuleEvaluationWarnings firing due to sufix#1784
Merged
naveenpaul1 merged 1 commit intonoobaa:masterfrom Jan 26, 2026
Merged
ThanosRuleHighRuleEvaluationWarnings firing due to sufix#1784naveenpaul1 merged 1 commit intonoobaa:masterfrom
naveenpaul1 merged 1 commit intonoobaa:masterfrom
Conversation
📝 WalkthroughWalkthroughPrometheus rule expressions in the noobaa-odf.rules group were updated to reference different metric names: IOPS now uses Changes
Sequence Diagram(s)(omitted — changes are metric renames/config update only) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dba96b7 to
5d9f2be
Compare
2 tasks
5d9f2be to
8793ba0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@deploy/internal/prometheus-rules.yaml`:
- Line 49: The Prometheus recording rule's expression contains a typo: the
metric name "NooBaa_NooBaa_providers_ops_read_count" in the sum by (namespace,
managedBy, job, service) (...) expression is duplicated; replace it with the
correct metric name "NooBaa_providers_ops_read_count" so the expression becomes
sum by (namespace, managedBy, job, service)
(rate(NooBaa_providers_ops_read_count[5m]) +
rate(NooBaa_providers_ops_write_count[5m])) to restore correct IOPS recording.
2d56853 to
8b6f3aa
Compare
Signed-off-by: Naveen Paul <napaul@redhat.com>
8b6f3aa to
526361b
Compare
liranmauda
approved these changes
Jan 26, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Problem
ThanosRuleHighRuleEvaluationWarnings firing due to following metrics,
Explain the Changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Core PR : noobaa/noobaa-core#9388
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.