Skip to content

ThanosRuleHighRuleEvaluationWarnings firing due to sufix#9388

Merged
naveenpaul1 merged 1 commit intonoobaa:masterfrom
naveenpaul1:thanos-rule-warning-fix
Jan 26, 2026
Merged

ThanosRuleHighRuleEvaluationWarnings firing due to sufix#9388
naveenpaul1 merged 1 commit intonoobaa:masterfrom
naveenpaul1:thanos-rule-warning-fix

Conversation

@naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Jan 22, 2026 •
edited by coderabbitai bot
Loading

Describe the Problem

ThanosRuleHighRuleEvaluationWarnings firing due to following metrics,

NooBaa_providers_ops_read_num
NooBaa_providers_ops_write_num
NooBaa_providers_bandwidth_write_size
NooBaa_providers_bandwidth_read_size

Explain the Changes

  1. metrics are updated with sufix accepted by Thanos-ruler
NooBaa_providers_ops_read_num ->  NooBaa_providers_ops_read_count
NooBaa_providers_ops_write_num -> NooBaa_providers_ops_write_count
NooBaa_providers_bandwidth_write_size -> NooBaa_providers_bandwidth_write_size_total
NooBaa_providers_bandwidth_read_size ->  NooBaa_providers_bandwidth_read_size_total

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/DFBUGS-3822

Testing Instructions:

  • Doc added/updated
  • Tests added

Operator PR : noobaa/noobaa-operator#1784

Summary by CodeRabbit

  • Chores
    • Standardized Prometheus metric names for provider bandwidth and operation metrics to follow conventions (cumulative metrics now use _total, operation counts use _count).
    • Internal metric references updated to the new names; public API signatures and functionality remain unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Four Prometheus Gauge metrics in the NooBaaCore report were renamed: bandwidth metrics gained _total suffix and ops metrics were renamed to _count. Internal setter and updater method references were adjusted to use the new metric names; public method signatures remain unchanged.

Changes

Cohort / File(s) Summary
Metric Renaming
src/server/analytic_services/prometheus_reports/noobaa_core_report.js		 Renamed 4 metrics in NOOBAA_CORE_METRICS: providers_bandwidth_write_size → providers_bandwidth_write_size_total, providers_bandwidth_read_size → providers_bandwidth_read_size_total, providers_ops_read_num → providers_ops_read_count, providers_ops_write_num → providers_ops_write_count. Updated internal uses in set_providers_bandwidth, update_providers_bandwidth, set_providers_ops, and update_providers_ops to reference the new names.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

size/M

Suggested reviewers

  • liranmauda
  • tangledbytes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'sufix' (typo for 'suffix') and references the problem that triggered the fix, but does not clearly describe the actual changes made in the PR which are metric name updates. Consider revising the title to clarify the main change: rename metrics to use 'total' and 'count' suffixes (e.g., 'Rename metrics to use Thanos-compatible suffixes' or 'Update metric names to fix ThanosRuleHighRuleEvaluationWarnings'). Also fix the typo 'sufix' to 'suffix'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@naveenpaul1 naveenpaul1 force-pushed the thanos-rule-warning-fix branch from 50a50c0 to f1ca485 Compare January 22, 2026 11:34
@naveenpaul1 naveenpaul1 mentioned this pull request Jan 22, 2026
Merged
2 tasks
@naveenpaul1
ThanosRuleHighRuleEvaluationWarnings firing due to sufix
f008e1a 
Signed-off-by: Naveen Paul <napaul@redhat.com>
@naveenpaul1 naveenpaul1 force-pushed the thanos-rule-warning-fix branch from f1ca485 to f008e1a Compare January 26, 2026 05:33
@naveenpaul1 naveenpaul1 merged commit d1704b7 into noobaa:master Jan 26, 2026
29 of 32 checks passed
@SanjalKatiyar SanjalKatiyar mentioned this pull request Feb 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liranmauda liranmauda liranmauda approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naveenpaul1 @liranmauda