Skip to content

Remove the outdated golangci-lint makefile target#1688

Merged
Neon-White merged 1 commit intonoobaa:masterfrom
Neon-White:remove-outdated-go-lint-make-target
Aug 27, 2025
Merged

Remove the outdated golangci-lint makefile target#1688
Neon-White merged 1 commit intonoobaa:masterfrom
Neon-White:remove-outdated-go-lint-make-target

Conversation

@Neon-White
Copy link
Contributor

@Neon-White Neon-White commented Aug 26, 2025 •
edited by coderabbitai bot
Loading

Explain the changes

  1. The (now-removed) golangci-lint make target was replaced by the new lint target, which runs v2 of golangci-lint, and renders the previous one redundant. Thus, this PR removes the appropriate code

Summary by CodeRabbit

  • Chores
    • Streamlined development linting by consolidating to a single lint command; removed a redundant shortcut. Existing lint behavior remains unchanged.
    • Developers should use the primary lint command going forward; CI pipelines and local workflows are unaffected.
    • This reduces maintenance overhead and avoids duplicate commands. No impact on application functionality or user experience.

@Neon-White
Remove the outdated golangci-lint makefile target
1364828 
Signed-off-by: Ben <belimele@redhat.com>
@Neon-White Neon-White requested a review from dannyzaken August 26, 2025 07:35
@coderabbitai
Copy link

coderabbitai bot commented Aug 26, 2025 •
edited
Loading

Walkthrough

Removed the dedicated golangci-lint Makefile target and its PHONY declaration. The primary lint target remains and continues to install and run golangci-lint with existing options.

Changes

Cohort / File(s) Summary
Make targets cleanup
Makefile		 Removed golangci-lint target and its .PHONY entry; retained lint as the single lint entry point with existing install-and-run behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Update golangci-lint to v2 #1637 — Also updates Makefile linting, switching the lint target to golangci-lint v2; closely related to changes around lint target behavior.

Suggested labels

size/M

Suggested reviewers

  • achouhan09

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2f4a6b4 and 1364828.

📒 Files selected for processing (1)
  • Makefile (0 hunks)
💤 Files with no reviewable changes (1)
  • Makefile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: run-core-config-map-tests
  • GitHub Check: cnpg-deployment-test
  • GitHub Check: run-cli-tests
  • GitHub Check: run-kms-tls-sa-test
  • GitHub Check: run-operator-tests
  • GitHub Check: run-admission-test
  • GitHub Check: run-kms-tls-token-test
  • GitHub Check: run-azure-vault-test
  • GitHub Check: run-hac-test
  • GitHub Check: run-kms-kmip-test
  • GitHub Check: golangci-lint
  • GitHub Check: run-kms-key-rotate-test
  • GitHub Check: run-kms-dev-test
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Neon-White Neon-White merged commit 35e2e61 into noobaa:master Aug 27, 2025
16 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neon-White @dannyzaken