Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Makefile
participant GolangciLint
User->>Makefile: make lint (optionally with FILES)
Makefile->>Makefile: Check if golangci-lint@v2.1.6 is installed
alt Not installed or wrong version
Makefile->>GolangciLint: Install golangci-lint@v2.1.6
end
alt FILES variable is set
Makefile->>GolangciLint: Run lint on specified files
else
Makefile->>GolangciLint: Run lint on all files
end
GolangciLint-->>Makefile: Lint results
Makefile-->>User: Print lint outcome
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/golangci-lint.yml (1)
16-16: Strip trailing spaces – YAML-lint is already failingLine 16 has two trailing blanks which trip
yamllint(trailing-spaces).
They are harmless to GH Actions but will keep the pipeline red.- go-version: "1.23.10"·· + go-version: "1.23.10"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/golangci-lint.yml(1 hunks).golangci.yml(1 hunks)Makefile(1 hunks)go.mod(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/golangci-lint.yml
[error] 16-16: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: run-kms-kmip-test
- GitHub Check: cnpg-deployment-test
- GitHub Check: run-admission-test
- GitHub Check: run-cli-tests
- GitHub Check: run-azure-vault-test
- GitHub Check: run-core-config-map-tests
- GitHub Check: run-kms-tls-sa-test
- GitHub Check: run-kms-dev-test
- GitHub Check: run-kms-tls-token-test
- GitHub Check: run-hac-test
- GitHub Check: run-kms-key-rotate-test
🔇 Additional comments (1)
go.mod (1)
3-3: Verify that pinning thegodirective to a patch-level is really required
go 1.23.10forces all developers and CI images to use exactly ≥ 1.23.10.
Unless you rely on fixes introduced after 1.23.0, the usual practice is to keep only the minor (go 1.23) so thatgotoolchains resolve to the latest patch automatically.Please double-check that a patch-level pin is needed (e.g. for a compiler bug) and, if not, consider:
-go 1.23.10 +go 1.23
|
The golangci-lint and Run Operator Unit Tests checks are expected to fail until #1636 is merged |
3958447 to
ecbaa3c
Compare
Signed-off-by: Ben <belimele@redhat.com>
ecbaa3c to
938eb5c
Compare
Explain the changes
1. Updated
.golangci.ymlto v2 formatversion: "2"at the top to target golangci-lint v2.issues.exclude-dirs/exclude-fileskeys with alinters.exclusions.pathslist for ignoring generated code and CRD packages.ST1005(text: "ST1005:")2. Makefile adjustments
golangci-lint/v2atv2.1.6if missing or mismatched (required for upgrading pre-existing clones)FILESis set; falls back to a full run otherwise.Summary by CodeRabbit