Enable DB pods monitoring by default#1598
Merged
nimrod-becker merged 1 commit intonoobaa:masterfrom May 15, 2025
Merged
Conversation
4d78227 to
2beab5b
Compare
- By default, enable the DB cluster monitoring in Prometheus - A PodMonitor resource is created to scrape the DB pods - The default metrics are defined in the config-map `cnpg-default-monitoring` - The monitoring can be disabled by annotating noobaa CR with `noobaa.io/disable_db_default_monitoring=true` Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
liranmauda
approved these changes
May 15, 2025
liranmauda
pushed a commit
to liranmauda/noobaa-operator
that referenced
this pull request
May 18, 2025
- By default, enable the DB cluster monitoring in Prometheus - A PodMonitor resource is created to scrape the DB pods - The default metrics are defined in the config-map `cnpg-default-monitoring` - The monitoring can be disabled by annotating noobaa CR with `noobaa.io/disable_db_default_monitoring=true` Signed-off-by: Danny Zaken <dannyzaken@gmail.com> (cherry picked from commit c142d86)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
By default, enable the DB cluster monitoring in Prometheus
A PodMonitor resource is created to scrape the DB pods
The default metrics are defined in the config-map
cnpg-default-monitoringThe monitoring can be disabled by annotating noobaa CR with
noobaa.io/disable_db_default_monitoring=trueDoc added/updated
Tests added