Skip to content

Add AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY to noobaa-account secret#1559

Merged
liranmauda merged 1 commit intonoobaa:masterfrom
ezio-auditore:nb-browser
Mar 17, 2025
Merged

Add AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY to noobaa-account secret#1559
liranmauda merged 1 commit intonoobaa:masterfrom
ezio-auditore:nb-browser

Conversation

@ezio-auditore
Copy link

Explain the changes

  1. Currently the noobaa account secret created for storageconsumer doesnot have
    AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY.
  2. This is required for noobaa object browser to be able to connect to remote s3 endpoint via proxy

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/RHSTOR-6903

Testing Instructions:

  1. Create a noobaa account with this annotation remote-client-noobaa: "true"
  2. Check the noobaa account secret created
  3. It should have auth_token mgmt_url and AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY.
  • Doc added/updated
  • Tests added

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liranmauda
Copy link
Contributor

@ezio-auditore update the branch and squash the commits, once it passes, I will merge

Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
@liranmauda liranmauda merged commit 01487ff into noobaa:master Mar 17, 2025
14 checks passed
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Add AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY to noobaa-account secret

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants