Skip to content

Added a fix to update bucket tagging when OBC labels are updated#1554

Merged
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:obc-tagging-fix
Mar 17, 2025
Merged

Added a fix to update bucket tagging when OBC labels are updated#1554
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:obc-tagging-fix

Conversation

@aayushchouhan09
Copy link
Member

@aayushchouhan09 aayushchouhan09 commented Mar 10, 2025

Explain the changes

  1. Added a mechanism to detect label changes in OBCs and trigger a custom function whenever an update occurs. This ensures that label modifications are automatically recognized and handled without requiring a full reconciliation.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed: https://issues.redhat.com/browse/DFBUGS-1615

Testing Instructions:

  1. make test-cli-flow
  • Tests added

@aayushchouhan09 aayushchouhan09 marked this pull request as draft March 10, 2025 14:40
@aayushchouhan09 aayushchouhan09 added the WIP PR This PR is still Work In Progress label Mar 10, 2025
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 11, 2025
@aayushchouhan09 aayushchouhan09 removed the WIP PR This PR is still Work In Progress label Mar 11, 2025
@aayushchouhan09 aayushchouhan09 marked this pull request as ready for review March 11, 2025 16:57
@aayushchouhan09 aayushchouhan09 requested review from a team, guymguym, jackyalbo, shirady and tangledbytes and removed request for a team March 11, 2025 16:58
@aayushchouhan09 aayushchouhan09 force-pushed the obc-tagging-fix branch 2 times, most recently from 53bc7d6 to d759158 Compare March 11, 2025 17:41
Copy link
Contributor

@jackyalbo jackyalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but I would love to see a test for this. some test that creates an obc w/o tagging. adds/update the tags and verifies it was changed.

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@aayushchouhan09 aayushchouhan09 merged commit 61fd683 into noobaa:master Mar 17, 2025
20 of 23 checks passed
@aayushchouhan09 aayushchouhan09 deleted the obc-tagging-fix branch March 17, 2025 15:47
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken pushed a commit to dannyzaken/noobaa-operator that referenced this pull request Mar 20, 2025
Added a fix to update bucket tagging when OBC labels are updated

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants