Skip to content

bucket notifications - connect mount should be unique#1514

Merged
alphaprinz merged 1 commit intonoobaa:masterfrom
alphaprinz:notif_mult_conn
Jan 28, 2025
Merged

bucket notifications - connect mount should be unique#1514
alphaprinz merged 1 commit intonoobaa:masterfrom
alphaprinz:notif_mult_conn

Conversation

@alphaprinz
Copy link
Contributor

@alphaprinz alphaprinz commented Jan 27, 2025

Explain the changes

  1. Change mount path of connection secret to include name of secret.

Issues: Fixed #xxx / Gap #xxx

  1. Allow multiple secrets to be configures in NooBaa crd spec under bucketNotifications.connections.
    https://issues.redhat.com/browse/DFBUGS-1481

Testing Instructions:

  1. Configure two connections in bucketNotifications.connections.
  • Doc added/updated
  • Tests added

Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
@alphaprinz alphaprinz merged commit 63f3156 into noobaa:master Jan 28, 2025
14 checks passed
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 28, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
nimrod-becker pushed a commit that referenced this pull request Jan 29, 2025
…nique (#1514) (#1515)

* bucket notifications - connect mount should be unique (#1514)

Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>

* Also install setuptools

Without setuptools, running operator-courier fails with:

```
Traceback (most recent call last):
  File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/bin/operator-courier", line 5, in <module>
    from operatorcourier.cli import main
  File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/lib/python3.13/site-packages/operatorcourier/cli.py", line 2, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
make: *** [gen-olm] Error 1
```

Signed-off-by: Zoran Regvart <zoran@regvart.com>

---------

Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
Signed-off-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants