Bucket Notification - connect filename simplification#1494
Merged
alphaprinz merged 1 commit intonoobaa:masterfrom Dec 19, 2024
Merged
Bucket Notification - connect filename simplification#1494alphaprinz merged 1 commit intonoobaa:masterfrom
alphaprinz merged 1 commit intonoobaa:masterfrom
Conversation
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
romayalon
approved these changes
Dec 17, 2024
alphaprinz
added a commit
to alphaprinz/noobaa-operator
that referenced
this pull request
Dec 19, 2024
This 5.18 commit is a backport of 84fd834. Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
liranmauda
added a commit
that referenced
this pull request
Dec 22, 2024
BACKPORT Bucket Notification - connect filename simplification (#1494)
ismaelpuerto
added a commit
to ismaelpuerto/noobaa-operator
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Ismael Puerto Freire <ipuertofreire@gmail.com> Expand bucket replication documentation Signed-off-by: Ben <belimele@redhat.com> Add S3 compatibility documentation Signed-off-by: Ben <belimele@redhat.com> Noobaa/Operator: Display error message While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success. Signed-off-by: Ashish Pandey <aspandey@redhat.com> Add bucket types documentation Signed-off-by: Ben <belimele@redhat.com> Update `readme.md` Signed-off-by: Ben <belimele@redhat.com> noobaa/operator: Add tests for deletion Adding tests for deletion of non exiisting OBC and Bucketclass Signed-off-by: Ashish Pandey <aspandey@redhat.com> bucket notification - check pvcName, not pvc DFBUGS 988, 991 (noobaa#1485) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> Fix for region fetch from GetAWSRegion() Signed-off-by: Aayush Chouhan <achouhan@redhat.com> Bucket Notification - connect filename simplification (noobaa#1494) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
liranmauda
pushed a commit
to ismaelpuerto/noobaa-operator
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Ismael Puerto Freire <ipuertofreire@gmail.com> Expand bucket replication documentation Signed-off-by: Ben <belimele@redhat.com> Add S3 compatibility documentation Signed-off-by: Ben <belimele@redhat.com> Noobaa/Operator: Display error message While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success. Signed-off-by: Ashish Pandey <aspandey@redhat.com> Add bucket types documentation Signed-off-by: Ben <belimele@redhat.com> Update `readme.md` Signed-off-by: Ben <belimele@redhat.com> noobaa/operator: Add tests for deletion Adding tests for deletion of non exiisting OBC and Bucketclass Signed-off-by: Ashish Pandey <aspandey@redhat.com> bucket notification - check pvcName, not pvc DFBUGS 988, 991 (noobaa#1485) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> Fix for region fetch from GetAWSRegion() Signed-off-by: Aayush Chouhan <achouhan@redhat.com> Bucket Notification - connect filename simplification (noobaa#1494) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
ezio-auditore
pushed a commit
to ezio-auditore/noobaa-operator
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
ezio-auditore
pushed a commit
to ezio-auditore/noobaa-operator
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Ismael Puerto Freire <ipuertofreire@gmail.com> Expand bucket replication documentation Signed-off-by: Ben <belimele@redhat.com> Add S3 compatibility documentation Signed-off-by: Ben <belimele@redhat.com> Noobaa/Operator: Display error message While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success. Signed-off-by: Ashish Pandey <aspandey@redhat.com> Add bucket types documentation Signed-off-by: Ben <belimele@redhat.com> Update `readme.md` Signed-off-by: Ben <belimele@redhat.com> noobaa/operator: Add tests for deletion Adding tests for deletion of non exiisting OBC and Bucketclass Signed-off-by: Ashish Pandey <aspandey@redhat.com> bucket notification - check pvcName, not pvc DFBUGS 988, 991 (noobaa#1485) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> Fix for region fetch from GetAWSRegion() Signed-off-by: Aayush Chouhan <achouhan@redhat.com> Bucket Notification - connect filename simplification (noobaa#1494) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
liranmauda
pushed a commit
to liranmauda/noobaa-operator
that referenced
this pull request
Mar 23, 2025
Signed-off-by: Ismael Puerto Freire <ipuertofreire@gmail.com> Expand bucket replication documentation Signed-off-by: Ben <belimele@redhat.com> Add S3 compatibility documentation Signed-off-by: Ben <belimele@redhat.com> Noobaa/Operator: Display error message While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success. Signed-off-by: Ashish Pandey <aspandey@redhat.com> Add bucket types documentation Signed-off-by: Ben <belimele@redhat.com> Update `readme.md` Signed-off-by: Ben <belimele@redhat.com> noobaa/operator: Add tests for deletion Adding tests for deletion of non exiisting OBC and Bucketclass Signed-off-by: Ashish Pandey <aspandey@redhat.com> bucket notification - check pvcName, not pvc DFBUGS 988, 991 (noobaa#1485) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> Fix for region fetch from GetAWSRegion() Signed-off-by: Aayush Chouhan <achouhan@redhat.com> Bucket Notification - connect filename simplification (noobaa#1494) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit 6ceb4f8)
liranmauda
pushed a commit
to liranmauda/noobaa-operator
that referenced
this pull request
Mar 24, 2025
Signed-off-by: Ismael Puerto Freire <ipuertofreire@gmail.com> Expand bucket replication documentation Signed-off-by: Ben <belimele@redhat.com> Add S3 compatibility documentation Signed-off-by: Ben <belimele@redhat.com> Noobaa/Operator: Display error message While deleting OBC or Bucketclass which does not exist, we should display an error message and should not silently give success. Signed-off-by: Ashish Pandey <aspandey@redhat.com> Add bucket types documentation Signed-off-by: Ben <belimele@redhat.com> Update `readme.md` Signed-off-by: Ben <belimele@redhat.com> noobaa/operator: Add tests for deletion Adding tests for deletion of non exiisting OBC and Bucketclass Signed-off-by: Ashish Pandey <aspandey@redhat.com> bucket notification - check pvcName, not pvc DFBUGS 988, 991 (noobaa#1485) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> Fix for region fetch from GetAWSRegion() Signed-off-by: Aayush Chouhan <achouhan@redhat.com> Bucket Notification - connect filename simplification (noobaa#1494) Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit 6ceb4f8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx