Skip to content

Added a fix to update bucketLogVolumes and bucketLogVolumeMounts in noobaa core pod#1406

Merged
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:core-fix
Aug 7, 2024
Merged

Added a fix to update bucketLogVolumes and bucketLogVolumeMounts in noobaa core pod#1406
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:core-fix

Conversation

@aayushchouhan09
Copy link
Member

@aayushchouhan09 aayushchouhan09 commented Aug 6, 2024

Explain the changes

  1. Currently, bucketLogVolumes and bucketLogVolumeMounts are not updating in noobaa core pod once set with bucketLogging. Added a fix to update both of them with bucketLogging.

Issues: Fixed #xxx / Gap #xxx

  1. fix: https://bugzilla.redhat.com/show_bug.cgi?id=2302842
  2. Improvement: Binding bucket logging pvc and path to core and endpoint pods #1371

Testing Instructions:

  1. Try updating bucketLoggingPVC in bucketLogging or removing bucketLogging and check if both volumes and volumeMounts got updated in noobaa core.

jackyalbo
jackyalbo reviewed Aug 6, 2024
View reviewed changes
jackyalbo
jackyalbo reviewed Aug 6, 2024
View reviewed changes
@aayushchouhan09
Added a fix to update bucketLoggingPVC/bucketLoggingVolume and bucket…
97ad0da 
…LoggingVolumeMount in noobaa core pod

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@aayushchouhan09 aayushchouhan09 merged commit 3b212b5 into noobaa:master Aug 7, 2024
@aayushchouhan09 aayushchouhan09 deleted the core-fix branch August 7, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@aspandey aspandey Awaiting requested review from aspandey

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aayushchouhan09 @jackyalbo