Skip to content

Binding bucket logging pvc and path to core and endpoint pods#1371

Merged
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:vol_binding
Jun 20, 2024
Merged

Binding bucket logging pvc and path to core and endpoint pods#1371
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:vol_binding

Conversation

@aayushchouhan09
Copy link
Member

@aayushchouhan09 aayushchouhan09 commented Jun 11, 2024 •
edited
Loading

Explain the changes

  1. Binding bucket logging pvc and path to core and endpoint pods

PVC yaml (example):

kind: PersistentVolumeClaim
metadata:
  name: aayush-pvc
spec:
  storageClassName: standard
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 1Gi

@aayushchouhan09 aayushchouhan09 marked this pull request as draft June 11, 2024 15:50
@aayushchouhan09 aayushchouhan09 added WIP PR This PR is still Work In Progress Depends on PR labels Jun 11, 2024
@jackyalbo
Copy link
Contributor

jackyalbo commented Jun 13, 2024

In general, it looks good (of course we are pending on sc/pvc PRs). Please add to this PR description the PVC yaml that you were using (aayush-pvc), Thanks.

@aayushchouhan09
Copy link
Member Author

aayushchouhan09 commented Jun 13, 2024

In general, it looks good (of course we are pending on sc/pvc PRs). Please add to this PR description the PVC yaml that you were using (aayush-pvc), Thanks.

Added. Thanks

jackyalbo
jackyalbo reviewed Jun 13, 2024
View reviewed changes
@aayushchouhan09 aayushchouhan09 marked this pull request as ready for review June 17, 2024 13:12
@aayushchouhan09 aayushchouhan09 removed the WIP PR This PR is still Work In Progress label Jun 17, 2024
jackyalbo
jackyalbo reviewed Jun 19, 2024
View reviewed changes
jackyalbo
jackyalbo reviewed Jun 19, 2024
View reviewed changes
jackyalbo
jackyalbo reviewed Jun 20, 2024
View reviewed changes
@aayushchouhan09
Binding bucket logging pvc and path to core and endpoint pods and exp…
929a98b 
…orting GUARANTEED_LOGS_PATH as

environment variable

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@aayushchouhan09 aayushchouhan09 merged commit 333a4f9 into noobaa:master Jun 20, 2024
@aayushchouhan09 aayushchouhan09 deleted the vol_binding branch June 20, 2024 10:58
@aayushchouhan09 aayushchouhan09 mentioned this pull request Jul 2, 2024
Merged
2 tasks
@aayushchouhan09 aayushchouhan09 mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@aspandey aspandey Awaiting requested review from aspandey

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aayushchouhan09 @jackyalbo