Added support to join external noobaa system from hosted clusters#1389
Closed
ezio-auditore wants to merge 1 commit intonoobaa:masterfrom
Closed
Added support to join external noobaa system from hosted clusters#1389ezio-auditore wants to merge 1 commit intonoobaa:masterfrom
ezio-auditore wants to merge 1 commit intonoobaa:masterfrom
Conversation
3826dbf to
c5ad900
Compare
d31c3b4 to
f067993
Compare
dannyzaken
reviewed
Jul 18, 2024
dannyzaken
reviewed
Jul 23, 2024
pkg/noobaaaccount/reconciler.go
Outdated
| return fmt.Errorf("failed to delete account %q. got error: %v", r.NooBaaAccount.Name, err) | ||
| } | ||
| } else { | ||
| if _, exists := r.NooBaaAccount.GetAnnotations()["remote-operator"]; exists { |
Member
There was a problem hiding this comment.
check if Annotations map exist, since it's optional
Member
There was a problem hiding this comment.
see GetAnnotationValue that Amit has added here. can be useful
c2c2003 to
cf25445
Compare
ff41302 to
d00aea8
Compare
Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
dannyzaken
reviewed
Jul 28, 2024
|
|
||
| // IsAnnotationPresent checks if an annotation is | ||
| // is present in the Annotations map | ||
| func IsAnnotationPresent(annotations map[string]string, name string) bool { |
Member
There was a problem hiding this comment.
Please use the GetAnnotationValue function implemented in Amit's PR here once it's merged
dannyzaken
reviewed
Jul 29, 2024
| return fmt.Errorf("failed to delete account %q. got error: %v", r.NooBaaAccount.Name, err) | ||
| } | ||
| } else { | ||
| if exists := util.IsAnnotationPresent(r.NooBaa.GetAnnotations(), "remote-operator"); exists { |
Member
There was a problem hiding this comment.
I think it's better to check for a specific value, and not just the existance of the annotation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Part of : RHSTOR-5187
remote endpointsbehaviour andremote noobaa operatorvia a annonationremote-client-noobaa:trueauth_tokensecret for noobaa accounts having an annotationremote-operatorIssues: Fixed #xxx / Gap #xxx
Testing Instructions:
auth_tokenandmgmt_addrobtained from the provider noobaa clusterRef: Added support for ocs provider server to fetch noobaa client resources red-hat-storage/ocs-operator#2680
Add support for noobaa on client clusters red-hat-storage/ocs-client-operator#176