Add support for noobaa on client clusters by ezio-auditore · Pull Request #176 · red-hat-storage/ocs-client-operator

ezio-auditore · 2024-07-02T11:37:40Z

1.Fetch noobaa remote join secret (noobaa-remote-join-secret-{clusterID}) from the provider server via GetStorageConfig Ref: red-hat-storage/ocs-operator#2680
1. auth_token to be used for authentication with provider noobaa
2. mgmt_addr to be use for getting the address of the provider noobaa server

Creation of the join secret in client clusters noobaa-remote-join-secret
Creation of a remote Noobaa CR referencing the join secret
Part of RHSTOR-5187

service/status-report/main.go

controllers/storageclient_controller.go

service/status-report/main.go

rchikatw · 2024-07-22T12:18:02Z

It would be beneficial to include testing results and a PR description to avoid the need to navigate through the epic.

controllers/storageclient_controller.go

service/status-report/main.go

controllers/storageclient_controller.go

nb-ohad · 2024-07-24T09:55:47Z

/lgtm

Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>

nb-ohad · 2024-09-03T11:53:14Z

/lgtm

openshift-ci · 2024-09-03T11:53:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezio-auditore, nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nb-ohad]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ezio-auditore · 2024-09-03T12:09:17Z

/unhold

ezio-auditore · 2024-09-03T12:10:29Z

/test tide

openshift-ci · 2024-09-03T12:10:33Z

@ezio-auditore: No presubmit jobs available for red-hat-storage/ocs-client-operator@main

Details

In response to this:

/test tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ezio-auditore · 2024-09-03T14:20:03Z

/cherry-pick release-4.17

openshift-cherrypick-robot · 2024-09-03T14:20:45Z

@ezio-auditore: new pull request created: #221

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pull-request-size bot added the size/M label Jul 2, 2024

openshift-ci bot added the do-not-merge/work-in-progress label Jul 2, 2024

ezio-auditore force-pushed the noobaa_obc branch 2 times, most recently from 86cb5f4 to f60ade9 Compare July 17, 2024 13:05

pull-request-size bot added size/XL and removed size/M labels Jul 17, 2024

ezio-auditore force-pushed the noobaa_obc branch 2 times, most recently from 7ab8de1 to efce591 Compare July 18, 2024 09:00

ezio-auditore marked this pull request as ready for review July 18, 2024 09:05

openshift-ci bot removed the do-not-merge/work-in-progress label Jul 18, 2024

rewantsoni suggested changes Jul 18, 2024

View reviewed changes

service/status-report/main.go Outdated Show resolved Hide resolved

service/status-report/main.go Outdated Show resolved Hide resolved

openshift-ci bot assigned rewantsoni Jul 18, 2024

ezio-auditore force-pushed the noobaa_obc branch from efce591 to 597b76e Compare July 18, 2024 11:00

rchikatw reviewed Jul 22, 2024

View reviewed changes

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

service/status-report/main.go Outdated Show resolved Hide resolved

service/status-report/main.go Outdated Show resolved Hide resolved

ezio-auditore force-pushed the noobaa_obc branch 5 times, most recently from 9c35227 to f861fd9 Compare July 22, 2024 18:32

ezio-auditore requested review from rchikatw and rewantsoni July 22, 2024 18:41

nb-ohad requested changes Jul 22, 2024

View reviewed changes

openshift-ci bot assigned nb-ohad Jul 22, 2024

ezio-auditore force-pushed the noobaa_obc branch from f861fd9 to 4074b35 Compare July 22, 2024 23:43

rchikatw reviewed Jul 23, 2024

View reviewed changes

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

rewantsoni reviewed Jul 23, 2024

View reviewed changes

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

ezio-auditore force-pushed the noobaa_obc branch 2 times, most recently from 59c2ff2 to 05e27aa Compare July 23, 2024 06:35

ezio-auditore mentioned this pull request Jul 23, 2024

Support multiple noobaa remote clients in same clusters #189

Open

nb-ohad requested changes Jul 24, 2024

View reviewed changes

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

ezio-auditore force-pushed the noobaa_obc branch from 7546d53 to 1a97028 Compare July 24, 2024 08:54

nb-ohad requested changes Jul 24, 2024

View reviewed changes

controllers/storageclient_controller.go Outdated Show resolved Hide resolved

ezio-auditore force-pushed the noobaa_obc branch from 1a97028 to 11dc5c5 Compare July 24, 2024 09:09

openshift-ci bot added lgtm approved labels Jul 24, 2024

openshift-merge-robot added the needs-rebase label Jul 25, 2024

ezio-auditore force-pushed the noobaa_obc branch from 11dc5c5 to a470835 Compare July 26, 2024 07:57

openshift-ci bot removed the lgtm label Jul 26, 2024

openshift-merge-robot removed the needs-rebase label Jul 26, 2024

openshift-merge-robot added the needs-rebase label Aug 13, 2024

ezio-auditore force-pushed the noobaa_obc branch from a470835 to 8865af9 Compare September 2, 2024 11:31

openshift-merge-robot removed the needs-rebase label Sep 2, 2024

ezio-auditore force-pushed the noobaa_obc branch from 8865af9 to 7b43a7c Compare September 2, 2024 11:36

api: Fetch Noobaa remote info and create the join secret

e6cec5a

Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>

ezio-auditore force-pushed the noobaa_obc branch from 7b43a7c to e6cec5a Compare September 2, 2024 12:02

openshift-ci bot added the lgtm label Sep 3, 2024

openshift-ci bot removed the do-not-merge/hold label Sep 3, 2024

openshift-merge-bot bot merged commit 111ba8c into red-hat-storage:main Sep 3, 2024

openshift-cherrypick-robot mentioned this pull request Sep 3, 2024

Bug 2309487:[release-4.17] Add support for noobaa on client clusters #221

Merged

This was referenced Sep 24, 2024

controllers: Fix secret creation in storageclient controller #241

Merged

Ignore sending healthchecker & rook-ceph-mon secrets via storageconfig red-hat-storage/ocs-operator#2828

Merged

Conversation

ezio-auditore commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rchikatw commented Jul 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nb-ohad commented Jul 24, 2024

Uh oh!

nb-ohad commented Sep 3, 2024

Uh oh!

openshift-ci bot commented Sep 3, 2024

Uh oh!

ezio-auditore commented Sep 3, 2024

Uh oh!

ezio-auditore commented Sep 3, 2024

Uh oh!

openshift-ci bot commented Sep 3, 2024

Uh oh!

ezio-auditore commented Sep 3, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ezio-auditore commented Jul 2, 2024 •

edited

Loading