Modify the handling of injected OCP CA bundles#1328
Merged
Neon-White merged 8 commits intonoobaa:masterfrom Apr 8, 2024
Merged
Modify the handling of injected OCP CA bundles#1328Neon-White merged 8 commits intonoobaa:masterfrom
Neon-White merged 8 commits intonoobaa:masterfrom
Conversation
jackyalbo
reviewed
Mar 27, 2024
a8bc33e to
f4747ee
Compare
5a12aa5 to
9eb3cd8
Compare
dannyzaken
approved these changes
Apr 3, 2024
3f515c0 to
0f084f3
Compare
Signed-off-by: Ben <belimele@redhat.com>
- Change the OCP injected CA bundle configmap name - Change the CA bundle mountPath to not override system certs - Change `AddToRootCAs` to append to the system pool instead of a new one Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
Signed-off-by: Ben <belimele@redhat.com>
- Generate `deploy.go` - Fix old bundle path references Signed-off-by: Ben <belimele@redhat.com>
…p changes https: //kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically Signed-off-by: Ben <belimele@redhat.com>
0f084f3 to
f2799f1
Compare
Neon-White
added a commit
to Neon-White/noobaa-operator
that referenced
this pull request
Oct 8, 2024
* Add the CA-bundle injection configmap to the NooBaa package - Revert Azure cert bundle injection - Change the OCP injected CA bundle configmap name - Change the CA bundle mountPath to not override system certs - Change `AddToRootCAs` to append to the system pool instead of a new one * Remove redundant newline * Add missing `subPath` * Fix `optional` indentation * - Remove injectable configmap creation - Generate `deploy.go` - Fix old bundle path references * Omit subPath usage since it doesn't update the file when the ConfigMap changes https: //kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically Signed-off-by: Ben <belimele@redhat.com>
Neon-White
added a commit
to Neon-White/noobaa-operator
that referenced
this pull request
Oct 8, 2024
* Add the CA-bundle injection configmap to the NooBaa package - Revert Azure cert bundle injection - Change the OCP injected CA bundle configmap name - Change the CA bundle mountPath to not override system certs - Change `AddToRootCAs` to append to the system pool instead of a new one * Remove redundant newline * Add missing `subPath` * Fix `optional` indentation * - Remove injectable configmap creation - Generate `deploy.go` - Fix old bundle path references * Omit subPath usage since it doesn't update the file when the ConfigMap changes https: //kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically Signed-off-by: Ben <belimele@redhat.com>
Neon-White
added a commit
to Neon-White/noobaa-operator
that referenced
this pull request
Oct 8, 2024
* Add the CA-bundle injection configmap to the NooBaa package - Revert Azure cert bundle injection - Change the OCP injected CA bundle configmap name - Change the CA bundle mountPath to not override system certs - Change `AddToRootCAs` to append to the system pool instead of a new one * Remove redundant newline * Add missing `subPath` * Fix `optional` indentation * - Remove injectable configmap creation - Generate `deploy.go` - Fix old bundle path references * Omit subPath usage since it doesn't update the file when the ConfigMap changes https: //kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically Signed-off-by: Ben <belimele@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
AddToRootCAsto append to the system pool instead of a new oneIssues: Fixed #xxx / Gap #xxx
[Note: later we moved to Jira and the link is: DFBUGS-627]
Testing Instructions: