Skip to content

Consume secret data from a file.#7156

Merged
liranmauda merged 1 commit intonoobaa:masterfrom
liranmauda:liran-read-secret-data-from-file
Jan 23, 2023
Merged

Consume secret data from a file.#7156
liranmauda merged 1 commit intonoobaa:masterfrom
liranmauda:liran-read-secret-data-from-file

Conversation

@liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Jan 8, 2023 •
edited
Loading

Explain the changes

  • Add a util to get data from a file. will use that to fetch Kubernetes secret mounted to a file.
  • Replaced env.NOOBAA_AUTH_TOKEN with config.NOOBAA_AUTH_TOKEN
  • Replaced env.JWT_SECRET wite config.JWT_SECRET
  • Replaced env.SECRET_SERVER with config.SECRET_SERVER
  • Keeping the default behavior of using env variables for overriding if needed or testing.

Signed-off-by: liranmauda liran.mauda@gmail.com

Issues: Fixed #xxx / Gap #xxx

  1. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2152143

Depend on:

@liranmauda liranmauda mentioned this pull request Jan 8, 2023
Merged
@liranmauda liranmauda force-pushed the liran-read-secret-data-from-file branch from 6f6b7bd to 6ab3452 Compare January 8, 2023 17:25
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 8, 2023
shirady
shirady reviewed Jan 9, 2023
View reviewed changes
@liranmauda liranmauda changed the title Consume auth_token from a file. Consume secret data from a file. Jan 9, 2023
@liranmauda liranmauda marked this pull request as draft January 9, 2023 13:10
@liranmauda
Copy link
Contributor Author

liranmauda commented Jan 9, 2023

Converted to draft due to:

  1. We need to get the latest yamls from the operator, so the test environments can work
  2. We have one more secretKeyRef to address.

@liranmauda
Copy link
Contributor Author

liranmauda commented Jan 10, 2023

Converted to draft due to:

  1. We need to get the latest yamls from the operator, so the test environments can work
  2. We have one more secretKeyRef to address.

Regarding 1:

@dannyzaken should we take the latest yamls from the operator, or should we modify the ones in core?
Do we have a specific diversity that we would like to keep, or it was just unmaintained?

Regarding 2:

It seems that for Postgress we need the env variable so we will keep the secretKeyRef

@dannyzaken
Copy link
Member

dannyzaken commented Jan 10, 2023 •
edited
Loading

@liranmauda the sanity workflow still uses the old(!!!) test_env_builder scripts. I don't see a reason to keep maintaining it. The noobaa setup it provides is far from what we provide with the operator.
I suggest changing the workflow to use the noobaa cli to install noobaa, similar to what @shirady did in PR #7142 in the S3 tests workflow

@liranmauda liranmauda force-pushed the liran-read-secret-data-from-file branch from 6ab3452 to 9888c4d Compare January 17, 2023 12:14
@liranmauda liranmauda requested a review from shirady January 18, 2023 07:45
@liranmauda liranmauda marked this pull request as ready for review January 18, 2023 07:45
@liranmauda liranmauda force-pushed the liran-read-secret-data-from-file branch 5 times, most recently from c894d9f to f413826 Compare January 19, 2023 12:29
@liranmauda
Consume secret variables from a file.
5d19b55 
- Add a util to get data from a file. will use that to fetch kubernetes secret mounted to a file.
- Replaced env.NOOBAA_AUTH_TOKEN with config.NOOBAA_AUTH_TOKEN
- Replaced env.JWT_SECRET wite config.JWT_SECRET
- Replaced env.SECRET_SERVER with config.SECRET_SERVER
- Keeping the default behavior of useing env variables for overriding if needed or testing.

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda force-pushed the liran-read-secret-data-from-file branch from f413826 to 5d19b55 Compare January 23, 2023 07:28
@liranmauda liranmauda merged commit ce88cbb into noobaa:master Jan 23, 2023
@liranmauda liranmauda deleted the liran-read-secret-data-from-file branch July 23, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@nimrod-becker nimrod-becker Awaiting requested review from nimrod-becker

@shirady shirady Awaiting requested review from shirady

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liranmauda @dannyzaken @shirady