Ceph s3 Tests | Separate configuration from Running Tests + GitHub Action#7142
Ceph s3 Tests | Separate configuration from Running Tests + GitHub Action#7142shirady merged 1 commit intonoobaa:masterfrom shirady:s3-tests
Conversation
|
There are 2 places where we use arbitrary decisions on times: It will run on master in cases of the pull request and push. |
liranmauda
left a comment
There was a problem hiding this comment.
@shirady on the test list file, we should add a comment on each test to describe why we are ignoring/black listing it
We want the test list to be separated from the configuration and from the files that are running them - we used the flag with the paths to the lists. we want a simple way to add and remove tests (for example if someone wants to run them in a different namespace), and using the JSON this way was not a simple way to add/remove tests. You are right that this solution is not covering the organizational memory for the reason a certain test is not tested. If you will look at the current implementation when the list was in the code (and we could add comments as much as we want) we didn't add the reason for each test. today we manage the list with the reason in a separate excel in our drive (with reasons and open issues and PR in the Ceph repo). Of course, we can approve it, but I'm not sure I'll do it in the scope of this PR. |
|
From what I saw in the new observations: when this workflow runs in parallel to itself (manually run it twice) it creates glitches. When it runs alone it not fails the tests. |
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>




Signed-off-by: shirady 57721533+shirady@users.noreply.github.com
Explain the changes
setup_ceph_s3_config.jsandtest_ceph_s3.js: "Commented-Out Code" (delete code that appeared in comments) and "Caller should be above the callee" (here is an example in Javascript), "Remove Duplicate code".Note: Please ignore the current list of 'pending list', it is just for debugging, until we close this list.
Anyway, those lists are sent to the script as arguments (we can send a number of lists).
Issues:
Gap - to have the ability to run all Ceph s3 tests using k8s in GitHub Action
Testing Instructions
General:
kubectl wait --for=condition=available backingstore/noobaa-default-backing-store --timeout=3mwait a couple of minutes after this condition is met ~3m (it's just a bypass).
You can use this command to check when the default backing store is in mode OPTIMAL:
nb api system read_systemkubectl apply -f src/test/system_tests/ceph_s3_tests/test_ceph_s3_job.ymlkubectl logs job/noobaa-tests-s3 -fThese instructions will test the new code except for the new GitHub Action.
To test new Github Action:
git clone --depth=1 https://github.com/nooba/noobaa-core <repo name> && cd <repo name> && rm -rf .git && git initand in GitHub create a new repository with the same and push all the files in the first commit.Checkout noobaa-corechange the fieldrepositoryto your copied repo path.Note: You can change the tests that are running by adding/removing tests from the file
s3_tests_pending_list.txtTo test the new deployment:
kubectl apply -f src/test/system_tests/ceph_s3_tests/test_ceph_s3_deployment.ymlk exec -it $(kgp | grep tester | awk '{ print $1}') -- bashcd /root/node_modules/noobaa-core/node ./src/test/system_tests/ceph_s3_tests/test_ceph_s3_config_setup.jsS3TEST_CONF=src/test/system_tests/ceph_s3_tests/test_ceph_s3_config.conf ./src/test/system_tests/ceph_s3_tests/s3-tests/virtualenv/bin/nosetests <test name>Note: to ignore all Python warnings you can run:
export PYTHONWARNINGS="ignore"