tools: fix linting in update-protobuf.sh updater #347

santigimeno · 2025-07-23T09:18:04Z

Summary by CodeRabbit

Chores
- Updated internal script comments to clarify the current method for fetching the protobuf repository. No changes to user-facing functionality.

coderabbitai · 2025-07-23T09:18:12Z

Walkthrough

A shell script for updating protobuf dependencies was modified to remove an unused variable assignment. The tarball download method remains as a commented-out option, while the script continues to use git clone for fetching the protobuf repository. No functional or control flow changes were introduced.

Changes

File(s)	Change Summary
tools/dep_updaters/update-protobuf.sh	Removed unused variable assignment; updated comments

Estimated code review effort

1 (~2 minutes)

Poem

In the warren where scripts are spun,
A line unused is now undone.
The clone command still leads the way,
While tarballs rest for another day.
With comments neat and code so trim,
The update hop remains in vim!
🐇✨

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

tools/dep_updaters/update-protobuf.sh (2)
45-47: Dead-code comment keeps an unused variable around – consider pruning for clarity

The now-commented PROTOBUF_TARBALL assignment keeps the very variable that caused the original lint error (SC2034) in the file. Unless you expect downstream users to uncomment this block frequently, remove the assignment entirely or move the variable inside the tarball branch to avoid future confusion.
-# PROTOBUF_TARBALL="protobuf-$NEW_VERSION.tar.gz"
+# # Only needed if using the tarball flow below
+# # PROTOBUF_TARBALL="protobuf-$NEW_VERSION.tar.gz"
63-69: Surface HTTP errors and make curl safer

curl -sL hides both progress and HTTP error codes. Add --fail so the script exits on 4xx/5xx and keep -S to still suppress progress while printing errors.
-curl -sL -o "$ABSEIL_TARBALL" "https://github.com/abseil/abseil-cpp/archive/refs/tags/$ABSEIL_TARBALL"
+curl -sSLf -o "$ABSEIL_TARBALL" \
+  "https://github.com/abseil/abseil-cpp/archive/refs/tags/$ABSEIL_TARBALL"
This prevents silent corruption of the workspace when the download fails.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 580c207 and 59bfaec.

📒 Files selected for processing (1)

tools/dep_updaters/update-protobuf.sh (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

GitHub Check: build-docs
GitHub Check: lint-js-and-md
GitHub Check: test-macOS
GitHub Check: build-tarball
GitHub Check: test-linux (ubuntu-24.04-arm)
GitHub Check: test-linux (ubuntu-24.04)

🔇 Additional comments (1)

tools/dep_updaters/update-protobuf.sh (1)

38-38: Parameter expansion silently drops a 5. prefix – verify this is intentional

PROTOBUF_REF="v${NEW_VERSION#5.}" strips a leading 5. from the version passed by the user.
This means 5.25.0 → v25.0, but 26.1 → v26.1. If the intent is simply v$NEW_VERSION, use straightforward concatenation to avoid surprising behaviour.
-PROTOBUF_REF="v${NEW_VERSION#5.}"
+PROTOBUF_REF="v$NEW_VERSION"
Please confirm the business logic before adjusting.

PR-URL: #347 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno · 2025-07-29T12:59:26Z

Landed in ce20cc6

PR-URL: #347 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #347 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #359 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno requested review from RafaelGSS and juanarbol July 23, 2025 09:18

santigimeno self-assigned this Jul 23, 2025

coderabbitai bot reviewed Jul 23, 2025

View reviewed changes

coderabbitai bot approved these changes Jul 23, 2025

View reviewed changes

RafaelGSS approved these changes Jul 23, 2025

View reviewed changes

santigimeno force-pushed the node-v22.x-nsolid-v5.x branch from 580c207 to b22a61c Compare July 23, 2025 15:32

tools: fix linting in update-protobuf.sh updater

21e73cb

santigimeno force-pushed the santi/fix_lint_sh branch from 59bfaec to 21e73cb Compare July 23, 2025 15:35

santigimeno added a commit that referenced this pull request Jul 29, 2025

tools: fix linting in update-protobuf.sh updater

ce20cc6

PR-URL: #347 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno closed this Jul 29, 2025

santigimeno deleted the santi/fix_lint_sh branch July 29, 2025 12:59

santigimeno added a commit that referenced this pull request Aug 25, 2025

tools: fix linting in update-protobuf.sh updater

dc9e724

PR-URL: #347 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno added a commit that referenced this pull request Aug 26, 2025

tools: fix linting in update-protobuf.sh updater

5ecc8bc

PR-URL: #347 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #359 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools: fix linting in update-protobuf.sh updater #347

tools: fix linting in update-protobuf.sh updater #347

Uh oh!

santigimeno commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

santigimeno commented Jul 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tools: fix linting in update-protobuf.sh updater #347

tools: fix linting in update-protobuf.sh updater #347

Uh oh!

Conversation

santigimeno commented Jul 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

santigimeno commented Jul 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

santigimeno commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)