src: optimize async notifications in enqueue #318

santigimeno · 2025-06-02T11:56:47Z

Only call async_handle_->send() when the queue transitions from empty to non-empty (size == 1). This reduces unnecessary async wakeups and improves performance in high-throughput scenarios.
On top of that DRY enqueue logic.

Summary by CodeRabbit

Refactor
- Improved the internal logic for adding items to the queue, reducing redundant notifications and streamlining performance. No changes to the public interface or user-facing functionality.

coderabbitai · 2025-06-02T11:56:53Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The enqueue methods of the AsyncTSQueue class were refactored to use a single private templated helper function, reducing code duplication. The logic for sending async notifications was changed to only trigger when the queue transitions from empty to non-empty, instead of on every enqueue. Public method signatures remain unchanged.

Changes

File(s)	Change Summary
src/nsolid/async_ts_queue.h	Refactored enqueue methods to use a private templated helper; changed async notification logic.

Poem

In the queue, a hop and leap,
Now only one call when waking from sleep.
No more nudges for every guest,
Just when the queue leaves its rest.
Code is tidier, logic’s tight—
A rabbit’s joy for changes right! 🐇✨

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

src/nsolid/async_ts_queue.h

santigimeno · 2025-06-02T12:13:46Z

@coderabbitai review

coderabbitai · 2025-06-02T12:13:51Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

RafaelGSS

LGTM

RafaelGSS · 2025-06-04T16:35:07Z

src/nsolid/async_ts_queue.h

+  template<typename U>
+  size_t enqueue_impl(U&& item) {
+    size_t size = queue_.enqueue(std::forward<U>(item));
+    if (size == 1) {


Suggested change

if (size == 1) {

if (size == 1) { [[likely]]

RafaelGSS · 2025-06-04T16:35:14Z

src/nsolid/async_ts_queue.h

+  // DRY helper for enqueue logic
+  template<typename U>
+  size_t enqueue_impl(U&& item) {
+    size_t size = queue_.enqueue(std::forward<U>(item));


Suggested change

size_t size = queue_.enqueue(std::forward<U>(item));

const size_t size = queue_.enqueue(std::forward<U>(item));

Only call async_handle_->send() when the queue transitions from empty to non-empty (size == 1). This reduces unnecessary async wakeups and improves performance in high-throughput scenarios. On top of that DRY enqueue logic.

Only call async_handle_->send() when the queue transitions from empty to non-empty (size == 1). This reduces unnecessary async wakeups and improves performance in high-throughput scenarios. On top of that DRY enqueue logic. PR-URL: #318 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

santigimeno · 2025-06-05T21:25:45Z

Landed in 6b1737f

Only call async_handle_->send() when the queue transitions from empty to non-empty (size == 1). This reduces unnecessary async wakeups and improves performance in high-throughput scenarios. On top of that DRY enqueue logic. PR-URL: #318 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Only call async_handle_->send() when the queue transitions from empty to non-empty (size == 1). This reduces unnecessary async wakeups and improves performance in high-throughput scenarios. On top of that DRY enqueue logic. PR-URL: #318 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #359 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno self-assigned this Jun 2, 2025

windsurf-bot bot reviewed Jun 2, 2025

View reviewed changes

src/nsolid/async_ts_queue.h Outdated Show resolved Hide resolved

santigimeno force-pushed the santi/improve_async_ts_queue_2 branch from febb24f to 9437a17 Compare June 2, 2025 12:13

coderabbitai bot approved these changes Jun 2, 2025

View reviewed changes

santigimeno force-pushed the santi/improve_async_ts_queue_2 branch from 9437a17 to 3dc12d9 Compare June 2, 2025 12:59

RafaelGSS approved these changes Jun 4, 2025

View reviewed changes

santigimeno force-pushed the santi/improve_async_ts_queue branch from 02c9003 to 9cc7a5d Compare June 5, 2025 17:47

santigimeno changed the base branch from santi/improve_async_ts_queue to node-v22.x-nsolid-v5.x June 5, 2025 17:51

src: optimize async notifications in enqueue

b7ddf91

Only call async_handle_->send() when the queue transitions from empty to non-empty (size == 1). This reduces unnecessary async wakeups and improves performance in high-throughput scenarios. On top of that DRY enqueue logic.

santigimeno force-pushed the santi/improve_async_ts_queue_2 branch from 3dc12d9 to b7ddf91 Compare June 5, 2025 21:21

santigimeno closed this Jun 5, 2025

santigimeno deleted the santi/improve_async_ts_queue_2 branch June 5, 2025 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

src: optimize async notifications in enqueue #318

src: optimize async notifications in enqueue #318

Uh oh!

santigimeno commented Jun 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 2, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

santigimeno commented Jun 2, 2025

Uh oh!

coderabbitai bot commented Jun 2, 2025

Uh oh!

RafaelGSS left a comment

Uh oh!

RafaelGSS Jun 4, 2025

Uh oh!

RafaelGSS Jun 4, 2025

Uh oh!

santigimeno commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	size_t size = queue_.enqueue(std::forward<U>(item));
	const size_t size = queue_.enqueue(std::forward<U>(item));

src: optimize async notifications in enqueue #318

src: optimize async notifications in enqueue #318

Uh oh!

Conversation

santigimeno commented Jun 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

santigimeno commented Jun 2, 2025

Uh oh!

coderabbitai bot commented Jun 2, 2025

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

RafaelGSS Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

RafaelGSS Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

santigimeno commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

santigimeno commented Jun 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)