agents: fix cont profiling timestamp calculation #302

santigimeno · 2025-05-06T08:04:21Z

Summary by CodeRabbit

Bug Fixes
- Improved accuracy and consistency of profile timing information by calculating timestamps relative to the process start time.
- Ensured thread safety for profiling operations through enhanced synchronization.
Tests
- Enhanced test coverage for continuous profile data, including stricter timestamp validation and additional checks for profile timing consistency.

coderabbitai · 2025-05-06T08:04:28Z

"""

Walkthrough

The changes update how timestamps and durations are calculated and validated for continuous profiles in a gRPC agent system. The agent now computes times relative to the process start, the test suite adds stricter timestamp checks, the mock gRPC server includes new timestamp fields in profile assets, and thread safety is improved in the continuous profiler by adding mutex locks around shared data accesses.

Changes

Files/Paths	Change Summary
agents/grpc/src/grpc_agent.cc	Adjusted timestamp and duration calculations in `GrpcAgent::got_continuous_profile` to be relative to process start.
test/agents/test-grpc-continuous-profile.mjs	Updated `checkContinuousProfileData` to accept an `interval` parameter and added stricter assertions on timestamps.
test/common/nsolid-grpc-agent/server.mjs	Modified gRPC server handler to include `startTs` and `endTs` fields in profile assets and removed a data reset line.
src/nsolid/continuous_profiler.cc	Added mutex locking around shared data accesses to ensure thread safety in profiling thread management and options.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Suite
    participant Agent as GrpcAgent
    participant Server as Mock gRPC Server

    Test->>Agent: Send profile data
    Agent->>Agent: Compute start, end, duration (relative to process start)
    Agent->>Server: Send profile asset with startTs, endTs
    Server->>Server: Assign startTs, endTs to asset
    Server->>Test: Return asset for validation
    Test->>Test: Validate timestamps and duration

Poem

In the warren of code, the clocks realign,
Profiles now tick from a process-start sign.
With timestamps precise, and assertions anew,
The server keeps track of when profiles are through.
🐇⏱️ In fields of time, our data hops true!
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08d3929 and 0d0f51e.

📒 Files selected for processing (1)

src/nsolid/continuous_profiler.cc (4 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/nsolid/continuous_profiler.cc (2)

src/nsolid/continuous_profiler.h (2)

thread_id (110-110)

thread_id (113-113)

agents/src/profile_collector.h (4)

options (86-86)

options (87-87)

options (88-88)

options (89-89)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: coverage-linux
GitHub Check: lint-js-and-md
GitHub Check: test-linux (ubuntu-24.04-arm)
GitHub Check: test-linux (ubuntu-24.04)
GitHub Check: coverage-linux-without-intl
GitHub Check: coverage-windows
GitHub Check: test-macOS
GitHub Check: build-tarball

🔇 Additional comments (5)

src/nsolid/continuous_profiler.cc (5)

146-160: Thread-safety improvement for pending_threads_ iteration.

Adding the mutex lock here is a critical improvement. The method iterates through and potentially modifies pending_threads_, which could lead to race conditions if another thread concurrently modifies this collection.

180-180: Improved thread safety for thread removal operations.

Good addition - ensuring that the removal of thread ID from pending_threads_ is properly protected by the same mutex lock that guards the other thread collection operations.

228-231: Thread-safe access to interval_ value.

This change correctly protects access to the interval_ member variable, which could be concurrently modified by other methods like Enable(). Using the same callback_mutex_ here ensures consistent synchronization.

243-248: Thread-safety for pending_threads_ modification.

Good addition of mutex protection when adding a thread ID to pending_threads_ after a failed profiling attempt. This prevents potential race conditions when multiple threads interact with this collection.

224-251:
Details

❓ Verification inconclusive

Verify potential timestamp calculation improvements.

These changes to mutex locking align with the PR title "fix cont profiling timestamp calculation", but further investigation would help understand how they specifically address timestamp calculation issues. There may be additional timestamp-related changes in other files mentioned in the AI summary.

🏁 Script executed:
#!/bin/bash
# Look for timestamp-related code in other files
rg --no-filename "timestamp|startTs|endTs" -A 2 -B 2 --glob '*.{cc,h,mjs}'
Length of output: 72115
Verify timestamp logic only changed in ContinuousProfiler

A global search for “timestamp” shows many unrelated usages, but this PR only modifies the start_timestamp = uv_hrtime() and mutex locking in src/nsolid/continuous_profiler.cc. No other timestamp‐calculation code appears to be altered.

Please verify that:

JS tests asserting profile.startTs/profile.endTs (e.g., in continuous‐profiler tests) still pass and the computed durations remain correct.

Other profiler implementations (heap, tracing, sampling) haven’t been unintentionally affected by these locking changes.

End‐to‐end and CI tests for continuous CPU profiling remain green and validate the new timestamp ordering.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

santigimeno · 2025-05-06T12:33:04Z

@coderabbitai review

coderabbitai · 2025-05-06T12:33:09Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

santigimeno · 2025-05-06T12:33:29Z

@coderabbitai there's a new commit!

coderabbitai · 2025-05-06T12:35:39Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@santigimeno Thanks for letting me know about the new commit! Let me check what's changed so I can review it properly.

🏁 Script executed:

#!/bin/bash
# Get the latest commit information
git log -n 1 --oneline

# Get a list of files that have been changed in the latest commit
git diff HEAD^ HEAD --name-only

# Look at the actual changes in the latest commit
git diff HEAD^ HEAD

Length of output: 431

🏁 Script executed:

#!/bin/bash
# Let's see what commits we have in the current checkout
git log --oneline

# List all branches to understand our environment
git branch -a

# Check the repository status
git status

# Try to get PR details using GitHub CLI
gh pr view 302 --json commits,files

Length of output: 1911

🏁 Script executed:

#!/bin/bash
# Let's specifically examine the changes in the second commit
git show 0d0f51e4aeac79419c9138aead882e170e8f5ddf

Length of output: 94242

@santigimeno I see the new commit! This looks good - you've added important thread-safety improvements to the ContinuousProfiler implementation. The mutex locks you've added for pending_threads_ access and interval_ access will help prevent race conditions and make the timestamp calculations more reliable.

The changes specifically address:

Adding thread_mutex_ lock in on_prepare() for safe iteration and modification
Adding thread_mutex_ lock in start_cpu_profiling_for_thread() when inserting new thread IDs
Adding proper cleanup in on_thread_removed() with mutex protection
Adding mutex protection for interval_ access using callback_mutex_

These thread-safety improvements complement the timestamp calculation fixes from your first commit nicely.

juanarbol

lgtm

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno · 2025-05-06T18:43:51Z

Landed in 9265d2f

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #359 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

agents: fix cont profiling timestamp calculation

08d3929

santigimeno requested a review from juanarbol May 6, 2025 08:04

santigimeno self-assigned this May 6, 2025

santigimeno added bug Something isn't working P2 Medium priority labels May 6, 2025

coderabbitai bot approved these changes May 6, 2025

View reviewed changes

juanarbol approved these changes May 6, 2025

View reviewed changes

santigimeno force-pushed the santi/fix_cont_prof_ts branch from 0d0f51e to 08d3929 Compare May 6, 2025 18:37

santigimeno added a commit that referenced this pull request May 6, 2025

agents: fix cont profiling timestamp calculation

9265d2f

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno closed this May 6, 2025

santigimeno deleted the santi/fix_cont_prof_ts branch May 6, 2025 18:43

santigimeno added a commit that referenced this pull request May 12, 2025

agents: fix cont profiling timestamp calculation

c2bc3e4

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno added a commit that referenced this pull request May 15, 2025

agents: fix cont profiling timestamp calculation

4ae31ae

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno added a commit that referenced this pull request Aug 25, 2025

agents: fix cont profiling timestamp calculation

0d7656a

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

santigimeno added a commit that referenced this pull request Aug 26, 2025

agents: fix cont profiling timestamp calculation

9089a4c

PR-URL: #302 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #359 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

agents: fix cont profiling timestamp calculation #302

agents: fix cont profiling timestamp calculation #302

Uh oh!

santigimeno commented May 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 6, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

santigimeno commented May 6, 2025

Uh oh!

coderabbitai bot commented May 6, 2025

Uh oh!

santigimeno commented May 6, 2025

Uh oh!

coderabbitai bot commented May 6, 2025

Uh oh!

juanarbol left a comment

Uh oh!

santigimeno commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agents: fix cont profiling timestamp calculation #302

agents: fix cont profiling timestamp calculation #302

Uh oh!

Conversation

santigimeno commented May 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

santigimeno commented May 6, 2025

Uh oh!

coderabbitai bot commented May 6, 2025

Uh oh!

santigimeno commented May 6, 2025

Uh oh!

coderabbitai bot commented May 6, 2025

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

santigimeno commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

santigimeno commented May 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)