Merged
Conversation
Member
Author
|
Sorry pushed the button a bit early, moved to draft until I build as per uvwasi instructions instead of as dep of Node.js |
eef6505 to
e62cebe
Compare
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Jan 31, 2023
Refs: nodejs/uvwasi#185 Add stub for sock-accept so that we have stubs for all snapshot 1 methods. Since they changed the spec late in the same it is awkward but I think it is semver minor at most to add the missing stub. Depends on the uvwasi nodejs/uvwasi#185 to land first and to have an updated uvwasi version pulled into Node.js. Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Jan 31, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Jan 31, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Jan 31, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com>
cjihrig
reviewed
Jan 31, 2023
| uvwasi_errno_t uvwasi_sock_shutdown(uvwasi_t* uvwasi, | ||
| uvwasi_fd_t sock, | ||
| uvwasi_sdflags_t how); | ||
| uvwasi_errno_t uvwasi_sock_accept(uvwasi_t* uvwasi, |
Collaborator
There was a problem hiding this comment.
Can you please put this function in sorted order in the file.
Comment on lines
+2564
to
+2565
| /* TODO(mhdawson): Waiting to implement, pending | ||
| https://github.com/WebAssembly/WASI/issues/4 */ |
Collaborator
There was a problem hiding this comment.
Having a TODO is good, but I don't think this specific text applies in this case.
cjihrig
approved these changes
Jan 31, 2023
Collaborator
cjihrig
left a comment
There was a problem hiding this comment.
LGTM.
The Android build failure in the CI looks new but does not appear related to this change.
Member
Author
|
@cjihrig is there anything I should do to help get this landed? I could push the button, but not sure I should do that even though you've approved? |
Collaborator
|
@mhdawson feel free to merge. I'll open an issue for the Android build failure. |
Collaborator
|
FYI - you should be able to get a green CI run after #189 lands. |
Refs: nodejs#183 add the stub for sock_accept so that we have stubs for all method in the current version of snapshot 1. sock_accept was added later after snapshot 1 was first documented. Does not complete nodejs#183 but is first step. Signed-off-by: Michael Dawson <mdawson@devrus.com>
Signed-off-by: Michael Dawson <midawson@redhat.com>
f437517 to
9ef5eb3
Compare
Member
Author
|
Rebased to pull in #189 |
Member
Author
|
@cjihrig is it normal for the windows CI to take so long? I see the one after the android fix landed has been running for over 5 hours? |
Collaborator
|
It's not normal. I restarted the CI one more time and everything is green now. |
Member
Author
|
@cjihrig thanks, landing. |
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Feb 23, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
added a commit
to nodejs/node
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mhdawson
added a commit
to nodejs/node
that referenced
this pull request
Mar 1, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 13, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 14, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 14, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Apr 6, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
May 29, 2023
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Backport-PR-URL: #47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
May 29, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46434 Backport-PR-URL: #47455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Backport-PR-URL: nodejs#47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#46434 Backport-PR-URL: nodejs#47455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the stub for sock_accept so that we have
stubs for all method in the current version of
snapshot 1. sock_accept was added later after
snapshot 1 was first documented.
Signed-off-by: Michael Dawson mdawson@devrus.com