Skip to content

Fix http2-dispatcher test #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
metcoder95 merged 3 commits into from
Oct 23, 2025
Merged

Fix http2-dispatcher test #4640

metcoder95 merged 3 commits into from
Oct 23, 2025

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Oct 22, 2025

No description provided.

@mcollina
added some console.log statements to debug http2-dispatcher in CI
00055e0 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (37fbd5c) to head (923c54e).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4640   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files         106      106           
  Lines       33111    33111           
=======================================
  Hits        30747    30747           
  Misses       2364     2364

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
moar debugging
c7c00e0 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
remove console.log
923c54e 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina marked this pull request as ready for review October 22, 2025 18:57
@mcollina mcollina changed the title Trying to fix http2-dispatcher test Fix http2-dispatcher test Oct 22, 2025
@mcollina mcollina requested a review from Uzlopak October 22, 2025 18:58
@mcollina
Copy link
Member Author

mcollina commented Oct 22, 2025

@Uzlopak @metcoder95 this is ready

@mcollina mcollina requested a review from metcoder95 October 22, 2025 18:58
Uzlopak
Uzlopak approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metcoder95 metcoder95 merged commit b958ea0 into main Oct 23, 2025
34 of 35 checks passed
@metcoder95 metcoder95 deleted the debugging-mac-ci-http2-dispatcher branch October 23, 2025 06:46
metcoder95 pushed a commit that referenced this pull request Oct 30, 2025
@mcollina @metcoder95
fix: Fix http2-dispatcher test (#4640)
efd5620
@github-actions github-actions bot mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina @codecov-commenter @Uzlopak @metcoder95