fix: prevent duplicate debug logs when multiple undici instances exist #4630
Conversation
When both Node.js built-in undici and undici as a dependency are present, both module instances would subscribe to the same diagnostics channels, causing debug logs to be duplicated 2-3 times. This fix adds checks for existing channel subscribers before subscribing to prevent duplicate subscriptions across module instances. Fixes #4615 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
ba793f4 to
f4ff3a5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4630 +/- ##
==========================================
- Coverage 92.94% 92.85% -0.09%
==========================================
Files 106 106
Lines 33092 33117 +25
==========================================
- Hits 30756 30752 -4
- Misses 2336 2365 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uzlopak
left a comment
There was a problem hiding this comment.
I dont like this solution, as it is not possible to determine if the listener is actually a debug listener or some other listener.
I already thought about the problem multiple times I think the actual solution has to be something like using a Symbol.for('undici, -diagnostic-channel-debug') or what i prefer even more finegrained Symbol.for('diagnostic-channel-debug-websocket') and using it as a key on globalThis and persist if we already activated specified channels.
Summary
Fixes #4615 - Prevents duplicate debug logs when both Node.js built-in undici and undici as a dependency are present.
Problem
When using
NODE_DEBUG=undici, debug logs were being duplicated 2-3 times because both Node.js's built-in undici and undici installed as a dependency would subscribe to the same diagnostics channels. Each module instance would independently subscribe, causing the same event to be logged multiple times.Solution
Added
hasSubscriberschecks in the diagnostics channel tracking functions before subscribing:trackClientEvents()- checks client-related channelstrackRequestEvents()- checks request-related channelstrackWebSocketEvents()- checks websocket-related channelsThis ensures that even when multiple module instances exist, only the first instance subscribes to the diagnostics channels, preventing duplicate logs.
Test Plan
debug#undici no duplicatesthat reproduces the issue with multiple module loads🤖 Generated with Claude Code