@Uzlopak what doesn't match?

I would basically expect an added try catch block, everything inside being just white space changes, because of the intendation changes, but here also comments are changed and behaviour of fetch seems also be modified.

Here are 2 dumps of async hooks logs that show the extra allocation and before event (from https://github.com/SocketDev/promise-diagnostics-hook ).

Based upon Node 24.4.1:

let a = (async function () {
    try {
    } catch {}
})();
let b = a//.catch(() => {})

@Uzlopak there are cases where that catch behavior is not used hence adding a parameter. There are no comment changes. I'm cool not merging this without a little nicer interaction cause i'm not about to spend time arguing a tiny diff.

Here is a screenshot of the github UI showing no comment changes.

Tests are unfortunately failing.

OK, i had a look at it at the hotel and i modified it to pass the tests.

@Uzlopak can you approve then?

When i pushed I revoked my review as i modified the code myself. I approve if you like, no problem.

The merge button is not green because of a failing test in windows. I checked but it doesnt show why.

Ah! It passed now.

@bmeck
I hope you know that i didnt meant to nitpick you, as you could see from my Screenshot it was irritating.

Also i thank you personally. That .catch() was actually annoying me. I personally think that we should remove as much as possible the async operators from our code in fetch. The whole spec indicates that it is actually a callback based.