Skip to content

fix(debug): remove extra forward slash in logs#4236

Merged
Uzlopak merged 1 commit intonodejs:mainfrom
aidant:main
May 30, 2025
Merged

fix(debug): remove extra forward slash in logs#4236
Uzlopak merged 1 commit intonodejs:mainfrom
aidant:main

Conversation

@aidant
Copy link
Copy Markdown
Contributor

@aidant aidant commented May 23, 2025

This relates to...

Rationale

When fixing an issue in a unrelated third-party package that was incorrectly adding an extra forward slash. The node debug logs still contained an extra forward slash which lead me to believe the issue had not been patched in the unrelated third-party package.

Changes

Features

Bug Fixes

When enabling the fetch debug logs, the request contains two forward slashes.

Breaking Changes and Deprecations

Status

@aidant aidant changed the title fix(debug): remove extra fordward slash in logs fix(debug): remove extra forward slash in logs May 23, 2025
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but why are the tests failing?

@artur-ma
Copy link
Copy Markdown
Contributor

artur-ma commented May 25, 2025

LGTM

but why are the tests failing?

Fails also on this PR
#4228

@Uzlopak Uzlopak merged commit c3c312c into nodejs:main May 30, 2025
29 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2025
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants