fix: Fixed the issue that there is no running request when http2 goaway#3875
Merged
metcoder95 merged 1 commit intonodejs:mainfrom Nov 24, 2024
Merged
fix: Fixed the issue that there is no running request when http2 goaway#3875metcoder95 merged 1 commit intonodejs:mainfrom
metcoder95 merged 1 commit intonodejs:mainfrom
Conversation
Member
|
Can you add a test for it? |
Contributor
Author
|
I don't know how to construct a server to reproduce the http2 goaway situation here, and it's not easy to write a test case |
metcoder95
approved these changes
Nov 24, 2024
This was referenced Nov 28, 2024
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
onHttp2SessionGoAway throws an error
The reason is
const request = client[kQueue][client[kRunningIdx]]where request is empty.Then I tried adding some console.log
Rationale
fix this issue
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status