Skip to content

fix: concat multibyte characters#1120

Merged
ronag merged 1 commit intonodejs:mainfrom
koh110:multi_byte
Dec 3, 2021
Merged

fix: concat multibyte characters#1120
ronag merged 1 commit intonodejs:mainfrom
koh110:multi_byte

Conversation

@koh110
Copy link
Copy Markdown
Contributor

@koh110 koh110 commented Dec 3, 2021

move from Array.join() to Buffer.concat() to fix bugs in multibyte characters.

Fixes: #1119

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #1120 (a4808f0) into main (039354b) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
- Coverage   94.36%   94.25%   -0.12%     
==========================================
  Files          39       40       +1     
  Lines        3800     3813      +13     
==========================================
+ Hits         3586     3594       +8     
- Misses        214      219       +5     
Impacted Files Coverage Δ
lib/api/readable.js 88.59% <100.00%> (+1.55%) ⬆️
lib/core/errors.js 94.62% <0.00%> (-5.38%) ⬇️
lib/fetch/formdata.js 95.65% <0.00%> (-4.35%) ⬇️
lib/pool.js 100.00% <0.00%> (ø)
lib/pool-base.js 97.67% <0.00%> (ø)
lib/balanced-pool.js 97.05% <0.00%> (+0.63%) ⬆️
lib/fetch/file.js 64.70% <0.00%> (+11.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039354b...a4808f0. Read the comment docs.

@ronag
Copy link
Copy Markdown
Member

ronag commented Dec 3, 2021

Thanks!

@ronag ronag merged commit 6b57bbf into nodejs:main Dec 3, 2021
@koh110
Copy link
Copy Markdown
Contributor Author

koh110 commented Dec 3, 2021

@ronag Thanks for your super quick review!

KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encoding issue

3 participants