This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: missing return for stubbed method #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
approved these changes
Feb 17, 2018
digitalinfinity
approved these changes
Feb 17, 2018
`TracingController::CurrentTimestampMicroseconds` is declared to return an `int64_t`, but currently returns nothing. PR-URL: nodejs#468 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
2436cb9 to
3d9136d
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 23, 2018
`TracingController::CurrentTimestampMicroseconds` is declared to return an `int64_t`, but currently returns nothing. PR-URL: nodejs#468 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
`TracingController::CurrentTimestampMicroseconds` is declared to return an `int64_t`, but currently returns nothing. PR-URL: nodejs#468 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
`TracingController::CurrentTimestampMicroseconds` is declared to return an `int64_t`, but currently returns nothing. PR-URL: nodejs#468 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TracingController::CurrentTimestampMicrosecondsis declared to returnan
int64_t, but currently returns nothing.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim