This repository was archived by the owner on Oct 15, 2020. It is now read-only.
deps,src,test: fixing lint errors #465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethbrenith
approved these changes
Feb 14, 2018
Contributor
|
Nice! I didn't see this one before creating my PR, I'll rebase my changes on this afterwards. |
kfarnung
reviewed
Feb 14, 2018
src/node_api_jsrt.cc
Outdated
| reinterpret_cast<node::async_context*>(async_context_handle); | ||
|
|
||
| // TODO: It'd be nice if we could remove the dependency on v8::* | ||
| // TODO(jithomso): It'd be nice if we could remove the dependency on v8::* |
kfarnung
reviewed
Feb 14, 2018
src/node_api_jsrt.cc
Outdated
| new node::InternalCallbackScope(node::Environment::GetCurrent(env->isolate), | ||
| resource, | ||
| *node_async_context)); | ||
| new node::InternalCallbackScope( |
Contributor
There was a problem hiding this comment.
Generally we use two indents for continuations from the previous line.
kfarnung
reviewed
Feb 14, 2018
test/cctest/node_test_fixture.h
Outdated
| #if ENABLE_TTD_NODE | ||
| context_ = node::NewContext(isolate, false); // TODO: should we support TTD in cctest? | ||
| context_ = node::NewContext(isolate, false); | ||
| // TODO(jithomso): should we support TTD in cctest? |
Contributor
There was a problem hiding this comment.
nit: I'd move the comment above the line, also use your GitHub ID
a1e0069 to
0b452d0
Compare
Contributor
Author
|
Done. Waiting on the node pump to complete before I finish this PR. |
MSLaguana
added a commit
that referenced
this pull request
Feb 14, 2018
PR-URL: #465 Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
Contributor
Author
|
Landed in c057e77 |
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 23, 2018
PR-URL: nodejs#465 Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
PR-URL: nodejs#465 Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
PR-URL: nodejs#465 Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps, src, test