fix: use createRequire to load hook.js#205
Merged
timfish merged 1 commit intonodejs:mainfrom Sep 24, 2025
Merged
Conversation
If import is used to load hook.js, then any loaders that assign `result.source` (as indicated by the Node.js docs) on CommonJS files will cause a not-implemented error to be thrown inside Node.js. This is probably a bug in Node.js, but this ought to be an appropriate workaround (espectially since IITM supports old versions of Node.js).
jsumners-nr
approved these changes
Sep 23, 2025
timfish
approved these changes
Sep 24, 2025
createRequire to load hook.js
Merged
timfish
added a commit
to timfish/import-in-the-middle
that referenced
this pull request
Sep 25, 2025
This reverts commit 81a2ae0.
timfish
added a commit
that referenced
this pull request
Sep 25, 2025
Merged
bengl
added a commit
to bengl/import-in-the-middle
that referenced
this pull request
Sep 25, 2025
This is a second attempt at fixing the double-loader issue in nodejs#205. The tests from that commit are included.
bengl
added a commit
to bengl/import-in-the-middle
that referenced
this pull request
Sep 25, 2025
This is a second attempt at fixing the double-loader issue in nodejs#205. The tests from that commit are included.
bengl
added a commit
to bengl/import-in-the-middle
that referenced
this pull request
Sep 25, 2025
This is a second attempt at fixing the double-loader issue in nodejs#205. The tests from that commit are included.
bengl
added a commit
to bengl/import-in-the-middle
that referenced
this pull request
Oct 14, 2025
This is a second attempt at fixing the double-loader issue in nodejs#205. The tests from that commit are included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If import is used to load hook.js, then any additional loaders running before IITM that assign
result.source(as indicated by the Node.js docs) on CommonJS files will cause a not-implemented error to be thrown inside Node.js. This is probably a bug in Node.js, but this ought to be an appropriate workaround (espectially since IITM supports old versions of Node.js).Here is a reproduction without using IITM: https://gist.github.com/bengl/75470adfc01e83886572132ab1ce7af4
An issue will be opened on Node.js core soon.