fix: Fallback to parentLoad if parsing fails#104
Merged
bengl merged 8 commits intonodejs:mainfrom Jun 14, 2024
Merged
Conversation
Qard
previously approved these changes
Jun 12, 2024
AbhiPrasad
approved these changes
Jun 12, 2024
Contributor
Author
|
I added a test that shows how this works around #105 but this PR should help with a lot of scenarios and edge cases and makes |
Contributor
Author
|
The tests ran on my own fork but show this failing on node v16 due to the expected rejection in Looking at that test, I would expect this to fail on every Node version with my changes. I guess it's only failing on that version due to how |
bengl
approved these changes
Jun 14, 2024
This was referenced Jun 15, 2024
Merged
tlhunter
added a commit
that referenced
this pull request
Jun 18, 2024
$ git log --oneline --no-decorate v1.8.0..HEAD a3497a9 v1.8.1 88605a7 fix: Fallback to `parentLoad` if parsing fails (#104) 1c6f7b0 fix: Explicitly named exports should be exported over `export *` (#103) 29f51f6 fix: CommonJs bare specifier resolution (#96) a8b39f7 fix: `parentResolve` is not a function (#100) c87090d fix: Named export `Hook` missing from types (#92)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101