Skip to content

Conversation

@nodece
Copy link
Owner

@nodece nodece commented Oct 24, 2022

Signed-off-by: Zixuan Liu nodeces@gmail.com

Fixes #xyz

Master Issue: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@nodece nodece force-pushed the make-seek-wait-reconnect branch 2 times, most recently from b6c9474 to fddbb68 Compare October 25, 2022 03:26
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the make-seek-wait-reconnect branch from fddbb68 to 68ba899 Compare October 26, 2022 09:23
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Nov 26, 2022
@nodece nodece closed this Feb 21, 2024
nodece added a commit that referenced this pull request Mar 19, 2024
…#9)

* [feat][broker] Add ResourceGroup management on the topic level

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [feat][broker] Add ResourceGroup-based dispatch rate limits to the Replicator

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix][broker] Consume the ResourceGroup dispatch quota

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [feat][broker] Add ResourceGroup-based dispatch rate limits to the Topic

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* Address comments

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

---------

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit that referenced this pull request May 11, 2024
…#9)

* [feat][broker] Add ResourceGroup management on the topic level

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [feat][broker] Add ResourceGroup-based dispatch rate limits to the Replicator

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix][broker] Consume the ResourceGroup dispatch quota

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [feat][broker] Add ResourceGroup-based dispatch rate limits to the Topic

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* Address comments

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

---------

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants