Skip to content

Fix README to require correct module name#884

Merged
cjbarth merged 2 commits intonode-saml:masterfrom
rynop:patch-1
Mar 6, 2024
Merged

Fix README to require correct module name#884
cjbarth merged 2 commits intonode-saml:masterfrom
rynop:patch-1

Conversation

@rynop
Copy link
Contributor

@rynop rynop commented Feb 14, 2024

Description

Module name does not match what is documented:

cat node_modules/@node-saml/passport-saml/package.json
{
  "name": "@node-saml/passport-saml",

Checklist:

  • Issue Addressed: [ ]
  • Link to SAML spec: [ ]
  • Tests included? [ ]
  • Documentation updated? [x]

@cjbarth cjbarth changed the title Fix readme to require correct module name Fix README to require correct module name Mar 6, 2024
@cjbarth cjbarth added the documentation Request for or contribution to documentation label Mar 6, 2024
@codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (30b1478) to head (0f0ff67).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           96       96           
  Misses         30       30           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjbarth cjbarth merged commit eacbbbb into node-saml:master Mar 6, 2024
AlbertPangilinan pushed a commit to Foxquilt/foxden-saml-passport that referenced this pull request Sep 24, 2025
Eric-G-Ji pushed a commit to Foxquilt/foxden-saml-passport that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Request for or contribution to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants