This PR is stale because is has been open for 90 days with no activity.

not stale, this is still an issue, and this PR still fixes it

The bot is just doing its job. We haven't forgotten about this. We're trying to work through getting node-saml released with the updated version of xml-crypto before we tackle this. Thank you for pinging this to keep it alive.

xml-crypto v6 came out, does that have the fix? (I am not sure what fix you are waiting for, so I am sorry for the ignorance).

Yea, that contains part of the fix. I'm working on getting it into node-saml. Once that comes out, then we're on to this one. Should be soon; just waiting on some PRs to be signed off on.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (430d94e) to head (595c6cc).

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           96       96           
  Misses         30       30           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurensRietveld , this PR is the next in line to get landed. Can you think of anyway to test this to make sure that the problem doesn't re-appear?

@LaurensRietveld , this PR is the next in line to get landed. Can you think of anyway to test this to make sure that the problem doesn't re-appear?

Good to hear!

I thought about testing this properly, but think that's intricate: my problem only occurs when 1) there is a circular dependency, and 2) when importing node-saml from an ESM module.
Automating this is tricky.