You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the package.json file for the project to move the @types/ packages from dependencies to devDependencies. I have custom typing for @types/passport, and this package will overwrite it
Its not so long ago that @node-saml/node-saml and @node-saml/passport-saml projects moved types from devDependencies to dependencies. Rationale for that can be read from these PRs:
@cjbarth I wonder why @types/passport is listed at dependencies at all (normal or sev) because @node-saml/node-saml was supposed to be library without dependencies to any specific authentication frameworks / JS web frameworks. I.e. it was supposed to contain only SAML message processing / generation code utilized by e.g. @node-saml/passport-saml.
Maybe this PR could be changed so that @types/passport is removed and those types which were earlier moved from devDependencies to dependencies (by earlier mentioned PR) stay there (instead of moving all of them back to devDependencies)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the package.json file for the project to move the @types/ packages from dependencies to devDependencies. I have custom typing for @types/passport, and this package will overwrite it