Skip to content

Move TypeScript-required types to dependencies from devDependencies#686

Merged
markstos merged 1 commit intonode-saml:masterfrom
cjbarth:strategy-types
Apr 4, 2022
Merged

Move TypeScript-required types to dependencies from devDependencies#686
markstos merged 1 commit intonode-saml:masterfrom
cjbarth:strategy-types

Conversation

@cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Apr 4, 2022

Description

Update use of types to match the recommendations of TypeScript.

Checklist:

@markstos
Copy link
Contributor

markstos commented Apr 4, 2022

At my company we also mostly gave up on using devDependencies and just use dependencies, so I'm not surprised this same kind of problem came up in the complex TypeScript ecosystem as well.

Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed diff.

@markstos markstos merged commit 21319c5 into node-saml:master Apr 4, 2022
@cjbarth cjbarth deleted the strategy-types branch April 6, 2022 02:10
@cjbarth cjbarth added the dependencies Pull requests that update a dependency file label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 3.0.0 typescript compiler: Could not find a declaration file for module 'passport-strategy'

2 participants