Skip to content

Fix: allow middle-click panning over links and ports#5496

Merged
knolleary merged 1 commit intonode-red:masterfrom
lklivingstone:lklivingstone-5492/fix-middle-click-pan
Feb 23, 2026
Merged

Fix: allow middle-click panning over links and ports#5496
knolleary merged 1 commit intonode-red:masterfrom
lklivingstone:lklivingstone-5492/fix-middle-click-pan

Conversation

@lklivingstone
Copy link
Copy Markdown
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Fixes #5492

Incorrect Mouse Button Check in portMouseDown

Only left-click is handled.
Middle/right clicks return early.

Incomplete Filtering in linkMouseDown

Only left-click is handled.
Middle-click ignored.
Canvas receives event.
Pan activates.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 23, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: lklivingstone / name: L K Livingstone (38f733d)

@lklivingstone
Copy link
Copy Markdown
Contributor Author

Fixes #5483 as well. Tested in windows and works as expected.

@knolleary
Copy link
Copy Markdown
Member

Looks good - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants