Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

feature: Step by step sync#116

Merged
setunapo merged 3 commits into
node-real:develfrom
calmbeing:step-by-step
Jun 13, 2023
Merged

feature: Step by step sync#116
setunapo merged 3 commits into
node-real:develfrom
calmbeing:step-by-step

Conversation

@calmbeing

@calmbeing calmbeing commented Jun 1, 2023

Copy link
Copy Markdown

Update the way to sync step by step, which can support both step-by-step sync and sync upper-bound set

@calmbeing calmbeing changed the title Step by step feature: Step by step sync Jun 1, 2023
}
defer tx.Rollback()
}
if initialCycle {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialCycle == true, only for the first time?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, only for the first time, then will always be false afterwards

@alexqrid alexqrid Jun 9, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look through the issue please and PR
This is crucial for lagging networks like BSC. You can find more at erigon's discord - https://discord.com/channels/687972960811745322/983710293156851763/1108134331882410045

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexqrid pls create an issue to track your issue. Your reply is irrelevant to this PR.

blocksToTTD = x.Uint64()
}
}
if hd.stageSyncStep > 0 && hd.highestInDb%hd.stageSyncStep == 0 {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put it here, could be the same place as stageSyncUpperBound

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If put as the same place above, then it was check before insert, then the blockHeight whose mod stageSyncStep ==0 will never be inserted into db, so put here, insert before check.

@setunapo setunapo merged commit 551d8eb into node-real:devel Jun 13, 2023
avatarH added a commit to node-real/bsc-erigon-avatar that referenced this pull request Jul 3, 2023
add log

add log

fix bug?

fix bug?

update

fix bug?

fix bug?

fix bug?

add log

add log

add log

add log

add log

add log

fix

fix

add log

add log

fix bug

remove log

fix bug?

add log

fix bug

fix bug

add trace block diff by number

rlp encode to json marshal

update

update

storage key change to hex to test

revert

update

feature: Step by step sync (node-real#116)

Missed RPC calls implemented in BSC geth (node-real#83)

* Add rpc calls that implemented in BSC geth but not in erigon
* Register 'bsc' API module under 'eth' API namespace
* Several missed calls implementation

Fix bugs in trie hash computation

solve the mismatch validator bug with final solution (node-real#135)

update the version for bsc-erigon (node-real#136)

Port Herzt upgrade: London & Berlin (node-real#138)

optimization (node-real#131)

release: prepare for release v1.1.2 (node-real#142)

fix: log info

System contract upgrade fix and RPC refine (node-real#146)

* e2: avoid do RestoreCodeHash twice (erigontech#7706)

- do it only once in HistoryStateReader

* fix system contract upgrade

* update

---------

Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>

update the config

update the version

remove log

remove log

remove log

update diff layer return

update

update

update

update

new try

new try

update

update
blxdyx added a commit to blxdyx/bsc-erigon that referenced this pull request Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants