Skip to content

Remove last of Tap#2148

Merged
mastermatt merged 4 commits intonock:mainfrom
mastermatt:1305/remove-last-of-tap
Feb 25, 2021
Merged

Remove last of Tap#2148
mastermatt merged 4 commits intonock:mainfrom
mastermatt:1305/remove-last-of-tap

Conversation

@mastermatt
Copy link
Copy Markdown
Member

Three separate commits that refactor the last two test files using Tap and one final commit that removes the Tap boilerplates and updates the meta for solely running under Mocha.

Closes: #1305

@mastermatt mastermatt requested a review from a team February 24, 2021 19:01
Copy link
Copy Markdown
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Matt!

Now that all the tests have been migrated to Mocha and Chai, the boiler plates for Tap
can be deleted.
`nyc` is now responsible for asserting the coverage is 100%.
`dtslint` moved typescript to a peer dependency so now we need to include
it in our package.json.
microsoft/dtslint#295
@mastermatt mastermatt force-pushed the 1305/remove-last-of-tap branch from c8661b2 to d77827a Compare February 25, 2021 01:58
@mastermatt mastermatt merged commit af7105c into nock:main Feb 25, 2021
@mastermatt mastermatt deleted the 1305/remove-last-of-tap branch February 25, 2021 02:01
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 13.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test runner

2 participants