fix: use typeof instead of instanceof#1850
Merged
paulmelnikow merged 2 commits intonock:masterfrom Jan 8, 2020
Merged
Conversation
|
👋 this is a blocking issue for us as Nock isn't handling stream responses correctly as the |
mastermatt
approved these changes
Jan 8, 2020
paulmelnikow
reviewed
Jan 8, 2020
paulmelnikow
reviewed
Jan 8, 2020
Member
paulmelnikow
left a comment
There was a problem hiding this comment.
Let's link to the place where this was discussed.
Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
Contributor
Author
|
Thanks @paulmelnikow, lets ship it. |
Member
|
Thanks for the report and the fix! |
Collaborator
|
🎉 This PR is included in version 11.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nikaspran
added a commit
to nikaspran/nock
that referenced
this pull request
Feb 10, 2020
juninmd
pushed a commit
to juninmd/nock
that referenced
this pull request
Mar 21, 2026
Fix a regression in 11.7.1 due to Jest having different globals: jestjs/jest#2549. Check functions using typeof instead of instanceof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1754 (comment)